v12.1.0 breaks compiled bindings / reduces type safety

[JaggerJo]

Describe the bug

We just tried to move from 12.0.x to 12.1 and now have a bunch of build errors related to the change made in #21617

Previously it was supported to bind commands to methods with a concrete parameter type, not it's required to be an object.

 Error AVLN2000 Avalonia: Unable to resolve method of name 'CopyTextToClipBoardCommand' on type 'ViewModel'.Expected method with no parameters or a single object overload.

This previously worked and made the method in the view model type safe:

With 12.1 we need to check if the parameter is actually of type string and change the CopyTextToClipBoardCommand method to take an object.

I get that this change was made intentionally - I just think this should be reconsidered.

To Reproduce

Create a command binding to a method that takes a non object parameter

Expected behavior

No response

Avalonia version

12.1

OS

No response

Additional context

No response

[maxkatz6]

I get that this change was made intentionally - I just think this should be reconsidered.

We went from undefined behavior, conflicted with reflection bindings, to a well-defined and consistent one.
But we absolutely can expand support for typed overloads now, for both compiled and reflection bindings, with a defined order.

[JaggerJo]

I get that this change was made intentionally - I just think this should be reconsidered.

We went from undefined behavior, conflicted with reflection bindings, to a well-defined and consistent one.
But we absolutely can expand support for typed overloads now, for both compiled and reflection bindings, with a defined order.

That would be great 👌

[RayZolo]

This is the only issue that prevents me from updating my app from 12.0.x to 12.1. I would love to update to v12.1, but there is no way I can justify downgrading my current strongly typed and compiled bindings for my axaml commands to the weakly typed object? parameter.

I agree it was important to improve the pre v12.1 reflection bindings, to a more strict model in v12.1. But that is not what we are talking about here. What this issue is about is that we do have well defined, non-conflicting, strongly typed, compiled bindings in pre v12.1, and v12.1 degraded this wonderful feature.

So, this is not an enhancement request, it is a bug report addressing what worked well in 12.0.x, and regressed with v12.1.

What can I as an Avalonia user and community member do to help fix this in v12.1?

[timunie]

~~@RayZolo you can provide a PR if you want to digg into it. But it's an area I cannot guide you. You may find the PR that changed it and start from there. ~~

Priorities can be requested having a support agreement.

EDIT: We will look into it, so don't open a PR as of now.

[JaggerJo]

@MrJul Thanks! You beat me time wise - was also working on the feature 😁