Repository navigation
Define _FILE_OFFSET_BITS=64 for OpenEXRCore explicitly - #2812
Merged
cary-ilm merged 2 commits intoNov 7, 2026
Merged
Conversation
OpenEXRCore's POSIX file I/O passes offsets and file sizes through off_t (pread, pwrite, lseek, fstat). On 32-bit glibc hosts, off_t is 32 bits unless compiled with _FILE_OFFSET_BITS=64, so without it, files of 2 GiB or more fail. OpenEXRCore has gotten that definition only indirectly, from OpenJPH's PUBLIC compile definitions, which it inherits from the vendored OpenJPH's target or an installed OpenJPH's CMake config, so the large-file support depended on how OpenJPH was found, and on OpenJPH continuing to define it. Define it for OpenEXRCore itself, PRIVATE since no public OpenEXRCore header uses off_t, in both the CMake and Bazel builds. Bazel uses OpenJPH from the Bazel Central Registry, so it didn't necessarily get the definition at all. Also add a _Static_assert in internal_posix_file_impl.h that off_t is 64 bits on glibc, the C library where it depends on this definition, so a 32-bit build (e.g. the Linux i686 CI job) fails to compile, rather than silently losing large-file support, if it's ever lost. Assisted-by: Copilot / Claude Opus 5.5 Signed-off-by: Cary Phillips <seabeepea@gmail.com>
cary-ilm
merged commit Nov 7, 2026
268fc5e
into
AcademySoftwareFoundation:main
39 of 40 checks passed
cary-ilm
added a commit
that referenced
this pull request
Nov 9, 2026
OpenEXRCore's POSIX file I/O passes offsets and file sizes through off_t (pread, pwrite, lseek, fstat). On 32-bit glibc hosts, off_t is 32 bits unless compiled with _FILE_OFFSET_BITS=64, so without it, files of 2 GiB or more fail. OpenEXRCore has gotten that definition only indirectly, from OpenJPH's PUBLIC compile definitions, which it inherits from the vendored OpenJPH's target or an installed OpenJPH's CMake config, so the large-file support depended on how OpenJPH was found, and on OpenJPH continuing to define it. Define it for OpenEXRCore itself, PRIVATE since no public OpenEXRCore header uses off_t, in both the CMake and Bazel builds. Bazel uses OpenJPH from the Bazel Central Registry, so it didn't necessarily get the definition at all. Also add a _Static_assert in internal_posix_file_impl.h that off_t is 64 bits on glibc, the C library where it depends on this definition, so a 32-bit build (e.g. the Linux i686 CI job) fails to compile, rather than silently losing large-file support, if it's ever lost. Assisted-by: Copilot / Claude Opus 5.5 Signed-off-by: Cary Phillips <seabeepea@gmail.com>
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Nov 15, 2026
## Version 3.5.4 (November 11, 2026) Patch release that addresses several build and security issues, and also fixes a regression introduced in v3.3.0 that leads to excessive memory usage during write, especially with DWA compression (Issue [#2791](AcademySoftwareFoundation/openexr#2791)). * Fix a configuration issue with OpenJPH 0.33.0 that caused it to silently and incorrectly fall back to the vendored version (PR [#2813](AcademySoftwareFoundation/openexr#2813)) * The vendored OpenJPH is now built in a custom namespace to avoid symbol collision with other versions when built statically ([2811](AcademySoftwareFoundation/openexr#2811)) built statically, * The vendored OpenJPH version is now 0.33.0. * Fix `exrmultipart -convert` on tiled and deep single-part files * `OPENEXR_USE_INTERNAL_IMATH/OPENJPH` are are now included in `OpenEXRConfig.h` alongside `OPENEXR_USE_INTERNAL_DEFLATE/ZSTD`. * 32-bit glibc builds now guarantee support for files of size 2GiB or more ([2812](AcademySoftwareFoundation/openexr#2812)) This release addresses the following security vulnerabilities: * ***CVE Pending*** ([GHSA-pp92-4rv3-wfq6](GHSA-pp92-4rv3-wfq6)) OpenEXR: a signed-int data-window-origin overflow in the OpenEXRUtil Image API turns `Imf::loadImage` into an attacker-steered out-of-bounds write * ***CVE Pending*** ([GHSA-2v77-pvhx-25c3](GHSA-2v77-pvhx-25c3)) Integer overflow in legacy OpenEXR.OutputFile.writePixels() causes heap over-read ### Merged Pull Requests * [2828](AcademySoftwareFoundation/openexr#2828) Add `OPENEXR_USE_INTERNAL_IMATH/OPENJPH` to BUILD.bazel (by @cary-ilm/Cary Phillips) * [2826](AcademySoftwareFoundation/openexr#2826) Find Threads in installed config before OpenJPH (by @cary-ilm/Cary Phillips) * [2824](AcademySoftwareFoundation/openexr#2824) Docs: make `maxSamplesPerPixel` optional for deep parts (by @cary-ilm/Cary Phillips) * [2823](AcademySoftwareFoundation/openexr#2823) Fix `exrmultipart -convert` on tiled and deep single-part files (by @cary-ilm/Cary Phillips) * [2818](AcademySoftwareFoundation/openexr#2818) Remove `test_write_overflow` (by @cary-ilm/Cary Phillips) * [2817](AcademySoftwareFoundation/openexr#2817) Fix integer overflow in legacy Python `OutputFile.writePixels()` (by @cary-ilm/Cary Phillips) * [2816](AcademySoftwareFoundation/openexr#2816) Fix integer overflow in OpenEXRUtil Image channel base pointers (by @cary-ilm/Cary Phillips) * [2814](AcademySoftwareFoundation/openexr#2814) CI: validate that the build uses the dependencies the job installed (by @cary-ilm/Cary Phillips) * [2813](AcademySoftwareFoundation/openexr#2813) Accept a newer OpenJPH, and warn when an installed one is too old (by @cary-ilm/Cary Phillips) * [2812](AcademySoftwareFoundation/openexr#2812) Define `_FILE_OFFSET_BITS=64` for OpenEXRCore explicitly (by @cary-ilm/Cary Phillips) * [2811](AcademySoftwareFoundation/openexr#2811) Rename vendored OpenJPH namespace, and hide zstd visibility (by @cary-ilm/Cary Phillips) * [2809](AcademySoftwareFoundation/openexr#2809) Reduce write memory (by @kdt3rd/Kimball Thurston) * [2808](AcademySoftwareFoundation/openexr#2808) Bump OpenJPH version to 0.33.0 (by @cary-ilm/Cary Phillips) * [2802](AcademySoftwareFoundation/openexr#2802) Use unaligned stores in the flat unpack fast paths (by @Ar-maan05/Armaan Sandhu) * [2798](AcademySoftwareFoundation/openexr#2798) Fix heap overflow in legacy Python `InputFile.channel()` with ySampling (by @Dilshad-Tanvi) * [2796](AcademySoftwareFoundation/openexr#2796) exrenvmap test: shrink output size and skip blur under QEMU emulation (by @cary-ilm/Cary Phillips) * [2794](AcademySoftwareFoundation/openexr#2794) Only zero the DWA chunk header instead of the full output buffer (by @vlazar-ilm/Vlad Lazar) * [2792](AcademySoftwareFoundation/openexr#2792) Fix `Python File.write()` over-reads for subsampled and RGB pixel arrays (by @Dilshad-Tanvi) * [2758](AcademySoftwareFoundation/openexr#2758) Fix tile chunk extents at reduced-resolution edges (by @vera-rubin/Nathan Chandrasekar) * [2734](AcademySoftwareFoundation/openexr#2734) Fix B44/B44A raw fallback when compressed size equals raw size (by @vera-rubin/Nathan Chandrasekar) ### Merged Workflow Pull Requests * [2835](AcademySoftwareFoundation/openexr#2835) release-notice: add workflow_dispatch to send announcements manually (by @cary-ilm/Cary Phillips) * [2834](AcademySoftwareFoundation/openexr#2834) ci: add `openjph_sha` to `ci_full/ci_premerge` with: blocks (by @cary-ilm/Cary Phillips) * [2832](AcademySoftwareFoundation/openexr#2832) Bump the actions-deps group across 1 directory with 2 updates (by @app/dependabot) * [2827](AcademySoftwareFoundation/openexr#2827) Bump CI's default OpenJPH to 0.33.0 (by @cary-ilm/Cary Phillips) * [2822](AcademySoftwareFoundation/openexr#2822) Bump the bazel-deps group with 2 updates (by @app/dependabot) * [2799](AcademySoftwareFoundation/openexr#2799) Fix missing step id breaking Slack release notifications (by @cary-ilm/Cary Phillips) * [2797](AcademySoftwareFoundation/openexr#2797) Bump the bazel-deps group with 3 updates (by @app/dependabot) * [2793](AcademySoftwareFoundation/openexr#2793) Bump the actions-deps group across 1 directory with 2 updates (by @app/dependabot)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenEXRCore's POSIX file I/O passes offsets and file sizes through off_t (pread, pwrite, lseek, fstat). On 32-bit glibc hosts, off_t is 32 bits unless compiled with _FILE_OFFSET_BITS=64, so without it, files of 2 GiB or more fail. OpenEXRCore has gotten that definition only indirectly, from OpenJPH's PUBLIC compile definitions, which it inherits from the vendored OpenJPH's target or an installed OpenJPH's CMake config, so the large-file support depended on how OpenJPH was found, and on OpenJPH continuing to define it.
Define it for OpenEXRCore itself, PRIVATE since no public OpenEXRCore header uses off_t, in both the CMake and Bazel builds. Bazel uses OpenJPH from the Bazel Central Registry, so it didn't necessarily get the definition at all.
Also add a _Static_assert in internal_posix_file_impl.h that off_t is 64 bits on glibc, the C library where it depends on this definition, so a 32-bit build (e.g. the Linux i686 CI job) fails to compile, rather than silently losing large-file support, if it's ever lost.
Assisted-by: Copilot / Claude Opus 5.5