Skip to content

Fixed regression in Imath::succf() and Imath::predf() when negative values are given (for 2.4) - #1013

Merged
cary-ilm merged 1 commit into
AcademySoftwareFoundation:RB-2.4from
cary-ilm:succf-fix
May 12, 2021
Merged

cary-ilm merged 1 commit into
AcademySoftwareFoundation:RB-2.4from
cary-ilm:succf-fix

Conversation

@cary-ilm

@cary-ilm cary-ilm commented May 7, 2021

Copy link
Copy Markdown
Member

Courtesy Christian Aguilera christian.aguilera@foundry.com

The issue was introduced in OpenEXR 2.4.0 as part of
c8a7f6a#diff-f09c17d3ab2fe5564e547c8461f1a43a6fe1109ebaf663a8463d1a9643c20ee0,
where the type of a member of a union was changed from signed to
unsigned, breaking comparison against > 0 a few lines below.

Since OpenEXR 2.4.0, Imath::predf(-2) returns -1.9999998807907104
instead of -2.000000238418579.

Test coverage has been added for this regression.

Fixes #999 (for the 2.4 line).

Signed-off-by: Cary Phillips cary@ilm.com

…alues are given

Courtesy Christian Aguilera <christian.aguilera@foundry.com>

The issue was introduced in OpenEXR 2.4.0 as part of
c8a7f6a#diff-f09c17d3ab2fe5564e547c8461f1a43a6fe1109ebaf663a8463d1a9643c20ee0,
where the type of a member of a union was changed from signed to
unsigned, breaking comparison against > 0 a few lines below.

Since OpenEXR 2.4.0, Imath::predf(-2) returns -1.9999998807907104
instead of -2.000000238418579.

Test coverage has been added for this regression.

Fixes AcademySoftwareFoundation#999 (for the 2.4 line).

Signed-off-by: Cary Phillips <cary@ilm.com>
@cary-ilm
cary-ilm merged commit cd985ea into AcademySoftwareFoundation:RB-2.4 May 12, 2021
cary-ilm pushed a commit to cary-ilm/openexr that referenced this pull request May 12, 2021
…alues are given (AcademySoftwareFoundation#1013)

Courtesy Christian Aguilera <christian.aguilera@foundry.com>

The issue was introduced in OpenEXR 2.4.0 as part of
c8a7f6a#diff-f09c17d3ab2fe5564e547c8461f1a43a6fe1109ebaf663a8463d1a9643c20ee0,
where the type of a member of a union was changed from signed to
unsigned, breaking comparison against > 0 a few lines below.

Since OpenEXR 2.4.0, Imath::predf(-2) returns -1.9999998807907104
instead of -2.000000238418579.

Test coverage has been added for this regression.

Fixes AcademySoftwareFoundation#999 (for the 2.4 line).

Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm pushed a commit that referenced this pull request May 16, 2021
* Fixed regression in Imath::succf() and Imath::predf() when negative values are given (#1013)

Courtesy Christian Aguilera <christian.aguilera@foundry.com>

The issue was introduced in OpenEXR 2.4.0 as part of
c8a7f6a#diff-f09c17d3ab2fe5564e547c8461f1a43a6fe1109ebaf663a8463d1a9643c20ee0,
where the type of a member of a union was changed from signed to
unsigned, breaking comparison against > 0 a few lines below.

Since OpenEXR 2.4.0, Imath::predf(-2) returns -1.9999998807907104
instead of -2.000000238418579.

Test coverage has been added for this regression.

Fixes #999 (for the 2.4 line).

Signed-off-by: Cary Phillips <cary@ilm.com>

* Release notes for v2.5.6 and updates to SECURITY.md

Signed-off-by: Cary Phillips <cary@ilm.com>

* Bump version for v2.5.6

Signed-off-by: Cary Phillips <cary@ilm.com>

* Change v2.5.6 release date to May 17, and clean up URL's

Signed-off-by: Cary Phillips <cary@ilm.com>
@cary-ilm
cary-ilm deleted the succf-fix branch May 18, 2021 03:25
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Jun 19, 2021
https://build.opensuse.org/request/show/900381
by user pgajdos + dimstar_suse
- security update
- added patches
  fix CVE-2021-3605 [bsc#1187395], Heap buffer overflow in the rleUncompress function
  + openexr-CVE-2021-3605.patch

- security update
- added patches
  fix CVE-2021-3598 [bsc#1187310], Heap buffer overflow in Imf_3_1:CharPtrIO:readChars
  + openexr-CVE-2021-3598.patch

- version update to 2.5.6
  * [#1013](AcademySoftwareFoundation/openexr#1013)
  Fixed regression in Imath::succf() and Imath::predf() when negative values are given
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants