Repository navigation
Fixed regression in Imath::succf() and Imath::predf() when negative values are given (for 2.4) - #1013
Merged
Conversation
…alues are given Courtesy Christian Aguilera <christian.aguilera@foundry.com> The issue was introduced in OpenEXR 2.4.0 as part of c8a7f6a#diff-f09c17d3ab2fe5564e547c8461f1a43a6fe1109ebaf663a8463d1a9643c20ee0, where the type of a member of a union was changed from signed to unsigned, breaking comparison against > 0 a few lines below. Since OpenEXR 2.4.0, Imath::predf(-2) returns -1.9999998807907104 instead of -2.000000238418579. Test coverage has been added for this regression. Fixes AcademySoftwareFoundation#999 (for the 2.4 line). Signed-off-by: Cary Phillips <cary@ilm.com>
meshula
approved these changes
May 10, 2021
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
May 12, 2021
…alues are given (AcademySoftwareFoundation#1013) Courtesy Christian Aguilera <christian.aguilera@foundry.com> The issue was introduced in OpenEXR 2.4.0 as part of c8a7f6a#diff-f09c17d3ab2fe5564e547c8461f1a43a6fe1109ebaf663a8463d1a9643c20ee0, where the type of a member of a union was changed from signed to unsigned, breaking comparison against > 0 a few lines below. Since OpenEXR 2.4.0, Imath::predf(-2) returns -1.9999998807907104 instead of -2.000000238418579. Test coverage has been added for this regression. Fixes AcademySoftwareFoundation#999 (for the 2.4 line). Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm
pushed a commit
that referenced
this pull request
May 16, 2021
* Fixed regression in Imath::succf() and Imath::predf() when negative values are given (#1013) Courtesy Christian Aguilera <christian.aguilera@foundry.com> The issue was introduced in OpenEXR 2.4.0 as part of c8a7f6a#diff-f09c17d3ab2fe5564e547c8461f1a43a6fe1109ebaf663a8463d1a9643c20ee0, where the type of a member of a union was changed from signed to unsigned, breaking comparison against > 0 a few lines below. Since OpenEXR 2.4.0, Imath::predf(-2) returns -1.9999998807907104 instead of -2.000000238418579. Test coverage has been added for this regression. Fixes #999 (for the 2.4 line). Signed-off-by: Cary Phillips <cary@ilm.com> * Release notes for v2.5.6 and updates to SECURITY.md Signed-off-by: Cary Phillips <cary@ilm.com> * Bump version for v2.5.6 Signed-off-by: Cary Phillips <cary@ilm.com> * Change v2.5.6 release date to May 17, and clean up URL's Signed-off-by: Cary Phillips <cary@ilm.com>
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jun 19, 2021
https://build.opensuse.org/request/show/900381 by user pgajdos + dimstar_suse - security update - added patches fix CVE-2021-3605 [bsc#1187395], Heap buffer overflow in the rleUncompress function + openexr-CVE-2021-3605.patch - security update - added patches fix CVE-2021-3598 [bsc#1187310], Heap buffer overflow in Imf_3_1:CharPtrIO:readChars + openexr-CVE-2021-3598.patch - version update to 2.5.6 * [#1013](AcademySoftwareFoundation/openexr#1013) Fixed regression in Imath::succf() and Imath::predf() when negative values are given
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Courtesy Christian Aguilera christian.aguilera@foundry.com
The issue was introduced in OpenEXR 2.4.0 as part of
c8a7f6a#diff-f09c17d3ab2fe5564e547c8461f1a43a6fe1109ebaf663a8463d1a9643c20ee0,
where the type of a member of a union was changed from signed to
unsigned, breaking comparison against > 0 a few lines below.
Since OpenEXR 2.4.0, Imath::predf(-2) returns -1.9999998807907104
instead of -2.000000238418579.
Test coverage has been added for this regression.
Fixes #999 (for the 2.4 line).
Signed-off-by: Cary Phillips cary@ilm.com