Repository navigation
[atomicsabi64] Document release fence using ISHST+ISHLD barriers - #351
Merged
Merged
Conversation
This allows more reordering than ISH.
smithp35
reviewed
Sep 15, 2025
| | ``atomic_thread_fence(release)`` | .. code-block:: none | | ||
| | | | | ||
| | ``atomic_thread_fence(acq_rel)`` | DMB ISH | | ||
| | | DMB ISHLD | |
Contributor
There was a problem hiding this comment.
To check my understanding, a combination of DMB ISHLD and DMB ISHST is a load-load, load-store and store-store barrier, but non store-load; but DMB ish is also a store-load barrier?
If so could be worth putting that or an explanation of why in the description/commit-message.
Contributor
Author
There was a problem hiding this comment.
I've added an explanation
reordering since the combination is not a store-load barrier.
smithp35
approved these changes
Sep 16, 2025
smithp35
left a comment
smithp35
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for the update.
Wilco1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows more reordering than ISH.