Evergreen

vandelay: record not appear selected after a merge target is selected - batch import/export MARC

Bug #1843837 reported by Tina Ji on 2019-09-12

This bug affects 4 people

	Status	Importance	Assigned to
Evergreen	Confirmed	Medium	Bill Erickson
3.11	Won't Fix	Undecided	Unassigned
3.12	Won't Fix	Medium	Unassigned
3.13	Won't Fix	Medium	Unassigned
3.15	Confirmed	Medium	Unassigned

Bug Description

EG 3.3.3

On the old interface: after selecting a merge target, go back to Import queue, the record with the selected target appear to be selected.

On the new interface, it is no longer selected.

Tags:

Terran McCanna (tmccanna) on 2019-09-13

tags:

added: cataloging vandelay

Jeff Davis (jdavis-sitka) on 2019-10-09

tags:

added: angular

Bill Erickson (berick) on 2019-10-11

Changed in evergreen:
assignee:	nobody → Bill Erickson (berick)

Bill Erickson (berick) on 2019-10-11

Changed in evergreen:
status:	New → Confirmed

Revision history for this message

Bill Erickson (berick) wrote on 2019-10-14:

Fix pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1843837-vand-merge-target-selected

From the commit:

After selecting an overlay target for a queued record in the MARC Import/Export Inspect Queue interface, the queued record row in question will be marked as selected upon returning to the Inspect Queue page. This is managed via a new grid @Input() attribute selectRowsOnLoad, which marks grid rows as selected as each row is rendered.

tags:	added: pullrequest
Changed in evergreen:
assignee:	Bill Erickson (berick) → nobody
milestone:	none → 3.4.1

Revision history for this message

Bill Erickson (berick) wrote on 2019-10-14:

Removed PR to make a small fix...

tags:	removed: pullrequest
Changed in evergreen:
assignee:	nobody → Bill Erickson (berick)

Revision history for this message

Bill Erickson (berick) wrote on 2019-10-14:

Alternate fix pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1843837-vand-persist-queue-selections

In addition to ensuring records with merge targets show as selected in the grid, this alternate version tracks import selection (with or without a merge target) across multiple renderings of the grid. With this, all selections are retained as users navigate to other interfaces (e.g. selecting merge targets) or apply grid filters, etc.

This is done by moving the grid row selection in-house so it's managed entirely by the vandelay service, similar to the Record Matches grid, instead of trying to synchronize selection criteria across vandelay and the grid.

tags:	added: pullrequest
Changed in evergreen:
assignee:	Bill Erickson (berick) → nobody

Evergreen Bug Maintenance (bugmaster) on 2019-10-28

Changed in evergreen:
milestone:	3.4.1 → 3.4.2

Evergreen Bug Maintenance (bugmaster) on 2020-01-27

Changed in evergreen:
milestone:	3.4.2 → 3.4.3

Revision history for this message

Bill Erickson (berick) wrote on 2020-04-24:

New branch pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1843837-vand-persist-queue-selections-1

Rebased to current master and includes a new commit to support Select All rows action. This was necessary to replace the functionality lost when disabling grid paging to support persistent grid import selection.

Jeff Davis (jdavis-sitka) on 2020-05-11

Changed in evergreen:
milestone:	3.4.3 → 3.5.0

Evergreen Bug Maintenance (bugmaster) on 2020-07-10

Changed in evergreen:
milestone:	3.5.0 → 3.5.1

Evergreen Bug Maintenance (bugmaster) on 2020-08-12

Changed in evergreen:
milestone:	3.5.1 → 3.5.2

Revision history for this message

Jennifer Weston (jweston) wrote on 2020-09-24:

Tested with Match Only Merge profile and 020 Record Match Set; loaded file to queue records at import.
Fix performs as expected. Selected target remains visibly selected when returning to the Inspect Queue page.

I have tested this code and consent to signing off on it with my name and my email address, Jennifer Weston, <email address hidden>

tags:

added: signedoff

Revision history for this message

Beth Willis (willis-a) wrote on 2020-09-25:

If you choose a merge/overlay target for a record with multiple matches and then return to the queue, the record(s) displays as selected. The records remain selected as the user navigates through multiple pages in vandelay interface.

But, if the user then checks the box to "Select All", any records that were selected become deselected.

Terran McCanna (tmccanna) on 2020-10-20

Changed in evergreen:
milestone:	3.5.2 → 3.6.1

Evergreen Bug Maintenance (bugmaster) on 2020-11-27

Changed in evergreen:
milestone:	3.6.1 → 3.6.2

Evergreen Bug Maintenance (bugmaster) on 2021-02-18

Changed in evergreen:
milestone:	3.6.2 → 3.6.3

Evergreen Bug Maintenance (bugmaster) on 2021-04-01

Changed in evergreen:
milestone:	3.6.3 → 3.6.4

Evergreen Bug Maintenance (bugmaster) on 2021-06-25

Changed in evergreen:
milestone:	3.6.4 → 3.7.2

Elaine Hardy (ehardy) on 2021-10-15

tags:

added: cat-importexport
removed: cataloging vandelay

Evergreen Bug Maintenance (bugmaster) on 2021-10-29

no longer affects:	evergreen/3.3
no longer affects:	evergreen/3.4
no longer affects:	evergreen/3.5
Changed in evergreen:
milestone:	3.7.2 → 3.7.3

Evergreen Bug Maintenance (bugmaster) on 2022-05-23

no longer affects:	evergreen/3.6
Changed in evergreen:
milestone:	3.7.3 → none

Terran McCanna (tmccanna) on 2022-10-04

Changed in evergreen:
milestone:	none → 3.9.1

Evergreen Bug Maintenance (bugmaster) on 2022-11-03

Changed in evergreen:
milestone:	3.9.1 → 3.9.2

Michele Morgan (mmorgan) on 2023-02-15

Changed in evergreen:
milestone:	3.9.2 → 3.10.1

Evergreen Bug Maintenance (bugmaster) on 2023-03-27

Changed in evergreen:
milestone:	3.10.1 → 3.10.2
importance:	Undecided → Medium

Evergreen Bug Maintenance (bugmaster) on 2023-05-18

Changed in evergreen:
milestone:	3.10.2 → 3.10.3

Jason Stephenson (jstephenson) on 2023-06-07

Changed in evergreen:
milestone:	3.10.3 → 3.12-beta

Bill Erickson (berick) on 2023-08-24

Changed in evergreen:
assignee:	nobody → Bill Erickson (berick)

Revision history for this message

Bill Erickson (berick) wrote on 2023-08-24:

Thanks Jennifer and Beth!

Rebased branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1843837-vand-persist-queue-selections-2

1. Includes Jennifer's sign-off
2. Adds another commit to address the issue raised by Beth (https://bugs.launchpad.net/evergreen/+bug/1843837/comments/6)

tags:	removed: signedoff
Changed in evergreen:
assignee:	Bill Erickson (berick) → nobody

Ruth Frasur Davis (redavis) on 2023-10-23

summary:	- vandelay: record not appear selected after a merge target is selected + vandelay: record not appear selected after a merge target is selected - + batch import/export
summary:	vandelay: record not appear selected after a merge target is selected - - batch import/export + batch import/export MARC

Evergreen Bug Maintenance (bugmaster) on 2023-11-20

Changed in evergreen:
milestone:	3.12-beta → 3.12-rc

Evergreen Bug Maintenance (bugmaster) on 2023-12-06

Changed in evergreen:
milestone:	3.12-rc → 3.next

Evergreen Bug Maintenance (bugmaster) on 2024-07-31

no longer affects:	evergreen/3.10
no longer affects:	evergreen/3.9
Changed in evergreen:
milestone:	3.next → 3.14-beta

Evergreen Bug Maintenance (bugmaster) on 2024-10-03

Changed in evergreen:
milestone:	3.14-beta → 3.14-rc

Evergreen Bug Maintenance (bugmaster) on 2024-10-17

Changed in evergreen:
milestone:	3.14-rc → 3.14.1

Evergreen Bug Maintenance (bugmaster) on 2024-11-21

Changed in evergreen:
milestone:	3.14.1 → 3.14.2

Evergreen Bug Maintenance (bugmaster) on 2024-12-20

Changed in evergreen:
milestone:	3.14.2 → 3.14.3

Evergreen Bug Maintenance (bugmaster) on 2025-01-16

Changed in evergreen:
milestone:	3.14.3 → 3.14.4

Revision history for this message

Jennifer Weston (jweston) wrote on 2025-02-02:

Attempted to test during BSW with admin|demo123 account and cannot get the import process to create a queue and load. Tested file and workflow on a 3.14 system and the file works. Just need attention to the test server to see if something is missing.

Evergreen Bug Maintenance (bugmaster) on 2025-02-18

Changed in evergreen:
milestone:	3.14.4 → 3.14.5

Evergreen Bug Maintenance (bugmaster) on 2025-04-15

Changed in evergreen:
milestone:	3.14.5 → 3.14.6

Evergreen Bug Maintenance (bugmaster) on 2025-05-21

Changed in evergreen:
milestone:	3.14.6 → 3.14.7

Evergreen Bug Maintenance (bugmaster) on 2025-06-19

Changed in evergreen:
milestone:	3.14.7 → 3.14.8

Revision history for this message

Carol Witt (carolwitt) wrote on 2025-07-08:

We tested this during today's CIG meeting and it worked as expected for Bibliographic Records, including successfully creating a queue and loading records.

I later tested it using a record with multiple potential matches. The selection remained when "Select All" is checked.

Clicking on a Matches link in an Authority Records queue displayed no details in the default Record Matches tab. Clicking on the Edit Record tab displayed the MARC and Import Items had the expected "Nothing to Display" message; the Queued Record MARC tab also displayed nothing.

Similarly, the I could view content in the Import Items tab in an Acquisitions Records queue, but nothing displayed in the Record Matches, Queued MARC Record, or Edit Record tabs.

Evergreen Bug Maintenance (bugmaster) on 2025-07-15

Changed in evergreen:
milestone:	3.14.8 → 3.14.9

Evergreen Bug Maintenance (bugmaster) on 2025-08-19

Changed in evergreen:
milestone:	3.14.9 → 3.14.10

Evergreen Bug Maintenance (bugmaster) on 2025-09-17

Changed in evergreen:
milestone:	3.14.10 → 3.14.11

Evergreen Bug Maintenance (bugmaster) on 2025-10-23

Changed in evergreen:
milestone:	3.14.11 → 3.14.12

Evergreen Bug Maintenance (bugmaster) on 2025-11-19

Changed in evergreen:
milestone:	3.14.12 → 3.15.8

Evergreen Bug Maintenance (bugmaster) on 2025-12-17

Changed in evergreen:
milestone:	3.15.8 → 3.15.9

Evergreen Bug Maintenance (bugmaster) on 2026-01-21

Changed in evergreen:
milestone:	3.15.9 → 3.15.10

Evergreen Bug Maintenance (bugmaster) on 2026-02-18

Changed in evergreen:
milestone:	3.15.10 → 3.15.11

Revision history for this message

Terran McCanna (tmccanna) wrote on 2026-03-19:

#10

Sounds like this needs additional work per comment #9

tags:

added: needswork
removed: pullrequest

Evergreen Bug Maintenance (bugmaster) on 2026-03-19

Changed in evergreen:
milestone:	3.15.11 → none

Terran McCanna (tmccanna) on 2026-03-25

Changed in evergreen:
assignee:	nobody → Bill Erickson (berick)

Revision history for this message

Carol Witt (carolwitt) wrote on 2026-10-12:

#11

This is still an issue in 3.17.4.

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.