Angular org selector / fm-editor required field validation issues

Branch implementing a fix for issue #1 above:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1838784-org-select-required

The fix for #2 will require building atop this branch.

Another example of this: In Local Admin -> Address Alerts, you can click "Save" on a new alert with no org unit selected, and you still see a "Success" toast message. (The alert isn't created.) Seeing a false "Success" message is bad.

Bill, I tested your branch, and it does show the Org Unit field as required now (with a red left-border). But I'm still able to save without choosing an Org Unit (and get the "Success" message). So it still needs to be considered when enabling the Save button (wherever that happens).

And now I see that is probably what you meant by #2. Okay, as you said, it looks like the fix for #1 is working.

Going to add the pullrequest tag so this can be tested for Feedback Fest next week.

Hi Bill, can you give this a rebase? Thanks!

Rebased:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1838784-org-select-required-v2

Well, on the plus side I can confirm that the fix for #1 does still work great. Unfortunately, #2 still seems to be a problem.

Removing pullrequest as per comment 7

I think this is useful enough that I'm going to mark it for pullrequest for issue #1, and then we can open a new bug for issue #2.

Noting that I've opened bug 2054233, which if successful would resolve both issues.

I do not share the opinion that a fix for #1 is enough as a stop-gap, as it could create a question in the user's mind regarding whether form validation is working at all.

Marking needsdiscussion as per Galen's comment #10

Here's a modification to the Fieldmapper Editor's Save button conditional to check the validity of required org unit selectors _in addition to_ the native form control validity. This isn't a universal form solution (see bug 2059142), but a) fm-editor is mostly where we run into this, and b) this logic could be copied into other reactive forms, at least until we refactor org-select as per bug 2054233.

Branch:
user/sleary/LP1838784-validate-org-select-in-fmeditor

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/LP1838784-validate-org-select-in-fmeditor

I had issues getting this to merge onto main today. Please rebase.