API deprecation update for KotlinModule - #744
Merged
Merged
Conversation
Direct reference to this constructor would cause bytecode compatibility problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the primary constructor of a
KotlinModuleis called directly, bytecode compatibility problems can occur.For this reason, this has been marked as
Deprecatedfor quite some time.This change raises the
DeprecationLevelto error and sets the privatization schedule to 2.18.In addition, hidden constructors and other builder functions marked as
Deprecatedthat have long been left out for compatibility purposes are also marked for removal in 2.18.At the same time, a hidden no-argument constructor has been added to facilitate initializing
KotlinModulevia reflection.This is useful in situations where
Javalibraries initializeKotlinModulevia reflection.However, the
Buildermethod of initialization is still recommended for normal use cases.