Skip to content

Add constructor accepting JsonMapperConfigurator to Jackson(Jaxb)JsonProvider #226

Description

@jolarsen

Hi,
I came across this when working on a jackson3-module for Jersey and adapting module-filtering to the Mapper-builder-pattern - more specifically the mappers created within MapperConfiguratorBase (defaultMapper...)

  • MapperConfiguratorBase have some abstract methods (mapperBuilder + Helper methods for sub-classes) that look suitable
  • My thought was to extend JsonMapperConfigurator, implement mapperBuilder or _builderWithConfiguration, and then extend JacksonJsonProvider and provide my MapperConfigurator. Looks cleaner than other options.
  • But JacksonJsonProvider / JacksonJaxbJsonProvider have no constructors that accept a custom MapperConfigurator - it only creates one.

Would adding constructors accepting custom MapperConfigurators be OK, or are there other considerations here?
If OK, I could make a quick PR adding such constructors to all 5 modules.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.xFor Jackson 3.x features, fixes

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions