Apply content converters for String collection values (StringCollectionDeserializer) - #6048
Merged
cowtowncoder merged 3 commits intoJun 22, 2026
Conversation
StringCollectionDeserializer only checked for content converters when no content deserializer had been resolved yet. This skipped @JsonDeserialize(contentConverter=...) for String collection properties that also use contentUsing. Move the converter lookup before the existing deserializer branch and add regression coverage for the combined contentUsing/contentConverter case.
🧪 Code Coverage Report
|
cowtowncoder
changed the title
StringCollectionDeserializer)
🧪 Code Coverage Report
|
cowtowncoder
approved these changes
Jun 22, 2026
Member
|
Thank you, @dlwldnjs1009 ! |
🧪 Code Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StringCollectionDeserializerskipped@JsonDeserialize(contentConverter=...)when a
Collection<String>property also specifiedcontentUsing, becausethe converter lookup only ran when no content deserializer had been resolved.
Changes:
contentUsing+contentConverteronList<String>.Testing:
./mvnw -Dtest=ConvertingDeserializerTest#testPropertyAnnotationStringListWithDeserializerLC test./mvnw -Dtest=ConvertingDeserializerTest test