@JsonView by-passed for unwrapped creator parameters [CVE-2026-54518] - #5971
Merged
cowtowncoder merged 3 commits intoMay 7, 2026
Merged
Conversation
🧪 Code Coverage Report
|
🧪 Code Coverage Report
|
cowtowncoder
marked this pull request as ready for review
May 7, 2026 01:25
🧪 Code Coverage Report
|
Member
Author
|
Fixed in:
|
cowtowncoder
added a commit
that referenced
this pull request
May 22, 2026
cowtowncoder
added a commit
that referenced
this pull request
May 22, 2026
cowtowncoder
added a commit
that referenced
this pull request
May 22, 2026
Honor the active @JSONVIEW in every property-based-creator buffering path, not just the originally-patched ones (sibling of #5969/#5971): - BuilderBasedDeserializer._deserializeUsingPropertyBased (regular-property branch) - BuilderBasedDeserializer.deserializeUsingPropertyBasedWithUnwrapped (creator + regular) - BeanDeserializer.deserializeUsingPropertyBasedWithUnwrapped (creator + regular) - BeanDeserializer.deserializeUsingPropertyBasedWithExternalTypeId (creator + regular) - BeanDeserializer._deserializeRecordForUpdate (creator) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
cowtowncoder
added a commit
that referenced
this pull request
May 22, 2026
dongjoon-hyun
added a commit
to apache/spark
that referenced
this pull request
Jun 5, 2026
### What changes were proposed in this pull request? This PR upgrades `FasterXML` `Jackson` to 2.21.4. ### Why are the changes needed? - https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.21.4 (2026-05-28) - FasterXML/jackson-core#1611 - FasterXML/jackson-databind#5931 - FasterXML/jackson-databind#5950 - FasterXML/jackson-databind#5951 - FasterXML/jackson-databind#5967 - FasterXML/jackson-databind#5969 - FasterXML/jackson-databind#5971 - FasterXML/jackson-databind#5974 - FasterXML/jackson-databind#5981 - FasterXML/jackson-databind#5988 - FasterXML/jackson-databind#5993 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 4.8) Closes #56338 from dongjoon-hyun/SPARK-57273. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
cowtowncoder
changed the title
@JsonView by-passed for unwrapped creator parameters@JsonView by-passed for unwrapped creator parameters [CVE-2026-54518]
cowtowncoder
added a commit
that referenced
this pull request
Jun 16, 2026
cowtowncoder
added a commit
that referenced
this pull request
Jun 16, 2026
cowtowncoder
added a commit
to pjfanning/jackson-databind
that referenced
this pull request
Jul 5, 2026
`ExternalTypeHandler` buffered external-type values and bound them without checking the active view, so a property hidden by `@JsonView` was still deserialized and set -- bypassing view-based filtering (same vulnerability class as GHSA-x94j-jhxw-j455 / [databind#5969], FasterXML#5971). Fix, all within `ExternalTypeHandler`: - both `complete(...)` overloads and the post-build set loop skip binding the value of any external property not visible in the active view - `complete(buffer, creator)` still assigns a *visible* external type id even when its value is view-hidden, so the [databind#999] type-id-as-creator- property case does not lose the (non-view) type id - `_deserializeAndSet` guards the eager-binding path, so default-constructor beans (where the type id precedes the value) are also covered Adds `JsonViewExternalTypeIdBypassTest` covering property-gated creator, admin-visible sanity, field-gated subtype, type-id-as-creator, and default-constructor cases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.