Fix NPE where code can look for an objectId when no _objectIdReader is set - #5686
Merged
Conversation
Member
|
@pjfanning I think it can only be triggered by YAML since it has native Object Ids (Anchors) unlike JSON. So I think fix is correct, thank you for submitting it. Will merge. |
_objectIdReader is set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://oss-fuzz.com/testcase-detail/4985209792823296
I'm not sure how to produce a test case for this but the failing OSS Fuzz scenario somehow leads to BeanDeserializer.deserializeFromObject calling _handleTypedObjectId but that latter method requires a non-null _objectIdReader.