Fix typo: MissingInjectableValueExcepion → MissingInjectableValueException - #5621
Merged
cowtowncoder merged 3 commits intoJan 28, 2026
Merged
Conversation
…ption Rename class introduced in FasterXML#5156 that was missing "t" in "Exception". Updated all references in DeserializationContext and test files.
🧪 Code Coverage Report
|
Member
|
Yes, we must retain old name as deprecated -- new correctly named one should be... sub-class, I think, of the now-deprecated wrongly-named class. That way if any existing code is catching or checking type with old class, things will still work. |
cowtowncoder
requested changes
Jan 28, 2026
cowtowncoder
left a comment
cowtowncoder
left a comment
Member
There was a problem hiding this comment.
As per my note, we must retain old incorrectly named exception type, deprecate it, and add new correctly named sub-type. This for 3.0-compatibility.
…bility Re-introduce the old misspelled class as a @deprecated base class (extends DatabindException) with fields and accessors intact. MissingInjectableValueException now extends the deprecated class as a thin subclass, preserving type compatibility for existing code that catches or checks the old exception type. - MissingInjectableValueExcepion: deprecated base with fields, getters, and from() factory that delegates to the new subclass - MissingInjectableValueException: thin subclass with constructor and from() only (fields/getters inherited) - Added backward-compatibility test verifying instanceof relationship
Contributor
Author
|
Thanks for the guidance! Updated in d0504b5:
This keeps existing catch/check logic working in 3.x. |
🧪 Code Coverage Report
|
| Object valueId, BeanProperty forProperty, Object beanInstance) | ||
| { | ||
| return new MissingInjectableValueExcepion(p, msg, valueId, forProperty, beanInstance); | ||
| return MissingInjectableValueException.from(p, msg, valueId, forProperty, beanInstance); |
cowtowncoder
approved these changes
Jan 28, 2026
🧪 Code Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix typo in exception class name:
MissingInjectableValueExcepion→MissingInjectableValueException(missing "t").Test plan