Skip to content

Add method copyCurrentStructureExact() to JsonGenerator - #1470

Merged
cowtowncoder merged 1 commit into
FasterXML:2.xfrom
cognitedata:copy_current_content_exact
Sep 17, 2025
Merged

Add method copyCurrentStructureExact() to JsonGenerator#1470
cowtowncoder merged 1 commit into
FasterXML:2.xfrom
cognitedata:copy_current_content_exact

Conversation

@larshagencognite

@larshagencognite larshagencognite commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

follows the format of copyCurrentEvent/copyCurrentEventExact

@larshagencognite
larshagencognite marked this pull request as ready for review September 9, 2025 10:09
pjfanning
pjfanning reviewed Sep 9, 2025
View reviewed changes
Comment thread src/test/java/com/fasterxml/jackson/core/write/GeneratorCopyTest.java Outdated
pjfanning
pjfanning reviewed Sep 9, 2025
View reviewed changes
Comment thread src/test/java/com/fasterxml/jackson/core/write/GeneratorCopyTest.java Outdated
@cowtowncoder

cowtowncoder commented Sep 9, 2025

Copy link
Copy Markdown
Member

Sounds good; hoping to get this reviewed soon.

@larshagencognite
larshagencognite force-pushed the copy_current_content_exact branch from f9d54df to 53c82ac Compare September 9, 2025 18:26
@cowtowncoder cowtowncoder changed the title add method copyCurrentStructureExact to JsonGenerator Add method copyCurrentStructureExact() to JsonGenerator Sep 11, 2025
cowtowncoder
cowtowncoder reviewed Sep 11, 2025
View reviewed changes
Comment thread src/test/java/com/fasterxml/jackson/core/write/GeneratorCopyTest.java Outdated
cowtowncoder
cowtowncoder reviewed Sep 11, 2025
View reviewed changes
Comment thread src/test/java/com/fasterxml/jackson/core/write/GeneratorCopyTest.java Outdated
@cowtowncoder cowtowncoder added the cla-needed PR looks good (although may also require code review), but CLA needed from submitter label Sep 11, 2025
@cowtowncoder

cowtowncoder commented Sep 11, 2025

Copy link
Copy Markdown
Member

Looks good mostly; added minor comments (including why unit tests fail).

But before merging, one process thing: need CLA:

https://github.com/FasterXML/jackson/blob/main/contributor-agreement.pdf

(unless one sent earlier,only needs to be done once before the first PR merged)

The usual way is to print, fill & sign, scan/photo, email to cla at fasterxml dot com.

Once I get that can final review, merge.

Thank you again for contributing this!

@larshagencognite
add method copyCurrentStructureExact to JsonGenerator
ad4e72c 
follows the format of copyCurrentEvent/copyCurrentEventExact
@larshagencognite
larshagencognite force-pushed the copy_current_content_exact branch from 53c82ac to ad4e72c Compare September 11, 2025 09:43
@larshagencognite

larshagencognite commented Sep 11, 2025

Copy link
Copy Markdown
Contributor Author

Running the CLA through my company's legal team now, hopefully I can sign it soon.

@cowtowncoder

cowtowncoder commented Sep 11, 2025

Copy link
Copy Markdown
Member

@larshagencognite Thank you! There is also alternate Corporate CLA (CCLA) -- https://github.com/FasterXML/jackson/blob/main/contributor-agreement-corporate.txt -- that some companies prefer (bigger, like FAANG), but majority of contributors use individual one. But both are acceptable for Jackson project.

@larshagencognite

larshagencognite commented Sep 16, 2025

Copy link
Copy Markdown
Contributor Author

I have sent the signed CLA now

@cowtowncoder cowtowncoder added cla-received PR already covered by CLA (optional label) and removed cla-needed PR looks good (although may also require code review), but CLA needed from submitter labels Sep 16, 2025
cowtowncoder
cowtowncoder approved these changes Sep 17, 2025
View reviewed changes

@cowtowncoder cowtowncoder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge

@cowtowncoder cowtowncoder added this to the 2.21.0 milestone Sep 17, 2025
@cowtowncoder
cowtowncoder merged commit 9afe389 into FasterXML:2.x Sep 17, 2025
7 checks passed
cowtowncoder added a commit that referenced this pull request Sep 17, 2025
@cowtowncoder
Add release notes wrt #1470
070e36c
@cowtowncoder

cowtowncoder commented Sep 17, 2025

Copy link
Copy Markdown
Member

Merged in for 2.21.0 and 3.0.0-rc10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes
@pjfanning pjfanning Awaiting requested review from pjfanning

Assignees

No one assigned

Labels

cla-received PR already covered by CLA (optional label)

Projects

None yet

Milestone

2.21.0

Development

Successfully merging this pull request may close these issues.

3 participants

@larshagencognite @cowtowncoder @pjfanning