You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Aim is to use this fix for patch releases but to later try a bigger change to better manage number state in the parser code - in the 2.19 development branch
pjfanning
changed the title
Lazy eval 2.17
fix issue where the parser has a number followed by an int where the int can be misinterpreted when read as a different type
Jan 25, 2025
pjfanning
changed the title
fix issue where the parser has a number followed by an int where the int can be misinterpreted when read as a different type
fix issue where the parser can read back old number state when parsing later numbers
Jan 25, 2025
Ok that sounds reasonable. One reason why I think this fix is not ideal is that it actually does not clear the state unless value is accessed -- so it just covers this specific case and not others. But at the same it is somewhat minimal fix which is a plus for patch releases.
cowtowncoder
changed the title
fix issue where the parser can read back old number state when parsing later numbers
Fix issue where the parser can read back old number state when parsing later numbers
Jan 27, 2025
Hmmmh. Playing with tests, the only fix that has any effect here is in getDoubleValue(), line 864. But it looks like _numberString is actually being cleared via convertNumberToDouble() which calls _getNumberDouble() where _numberString is actually cleared.
I think I'll trim down changes slowly to parts that seem useful in general (namely, immediate return after "convertXxx()" calls). And then look into 2.19 for more general clearing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.