Fix infinite loop due to integer overflow when reading large strings - #1352
Merged
Conversation
Member
|
@pjfanning Agree wrt 2.17 branch: while seems like a rare case (*), if it happens, result is pretty bad. So it getting fixed for 2.17.3 would be great. I hope to get this reviewed and merged ASAP, within time constraints I have on my end. (*) given also that I think it may well fail for other reason for text segment over 2 gigs, due to Java's limits on |
cowtowncoder
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #1350
I had to set a very large Xmx (eg -Xmx24G) to get the test to run and that's after I rewrote the test in #1350 to cut down on the memory needed.