`TokenStreamFactory.createNonBlockingByteBufferParser()` return type wrong

[hb16]

Both createNonBlockingByteArrayParser() and createNonBlockingByteBufferParser() in TokenStreamFactory have the same type bound for the return type:

P extends JsonParser & ByteArrayFeeder

I'd expect the type for createNonBlockingByteBufferParser() to be

P extends JsonParser & ByteBufferFeeder.

Is this a copy-paste error or am I missing something?

[pjfanning]

@hb16 the method signature is wrong - can you use JsonFactory for now? JsonFactory has the method and you can cast its return type to ByteBufferFeeder. We will try to fix the return types in an upcoming release.

[cowtowncoder]

Definitely copy-paste fail. Embarrassing.

[cowtowncoder]

Fixed by #1528

[pjfanning]

You'd really have expected that the Java parser would have prevented this.

[cowtowncoder]

@pjfanning I think part of the problem was override in JsonFactory that used too generic return type, instead of indicating mismatch with TokenStreamFactory base typing.