Skip to content

Consider re-adding "shouldnot" to allow dictionary #2528

Closed

Description

@jackfrancis

Hi folks,

It seems that w/ today's v2.2.2 release the word "shouldnot" has been demoted to "not allowed by default". Because terms like Should and ShouldNot are rather common in test assertion libraries across the developer ecosystem, I wonder if other folks had to quickly update their ignore files today to unblock CI.

Here's one example of some usages in the golang ginkgo test framework:

Thanks for consideration!

Activity

  1. peternewman commented on Oct 17, 2022

    @peternewman
    Collaborator

    Hi @jackfrancis ,

    While it's clearly not a valid word, please feel free to open a PR to move it into the code dictionary, then it won't be enabled by default only if people request to scan with that dictionary (hopefully not on code).

  2. added a commit that references this issue on Feb 19, 2023
    0bc82ab
  3. added a commit that references this issue on Feb 19, 2023
    f7aba56
  4. jackfrancis commented on Feb 19, 2023

    @jackfrancis
    Author
  5. DimitriPapadopoulos commented on Feb 20, 2023

    @DimitriPapadopoulos
    Collaborator

    You're welcome and thank you for this contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dictionaryChanges to the dictionary

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions