You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Consider re-adding "shouldnot" to allow dictionary #2528
It seems that w/ today's v2.2.2 release the word "shouldnot" has been demoted to "not allowed by default". Because terms like Should and ShouldNot are rather common in test assertion libraries across the developer ecosystem, I wonder if other folks had to quickly update their ignore files today to unblock CI.
Here's one example of some usages in the golang ginkgo test framework:
While it's clearly not a valid word, please feel free to open a PR to move it into the code dictionary, then it won't be enabled by default only if people request to scan with that dictionary (hopefully not on code).
Activity
peternewman commentedon Oct 17, 2022
Hi @jackfrancis ,
While it's clearly not a valid word, please feel free to open a PR to move it into the code dictionary, then it won't be enabled by default only if people request to scan with that dictionary (hopefully not on code).
Move `shouldnot` to code dictionary (Fixes codespell-project#2528)
Move `shouldnot` to code dictionary (Fixes #2528)
jackfrancis commentedon Feb 19, 2023
Thank you @DimitriPapadopoulos !
DimitriPapadopoulos commentedon Feb 20, 2023
You're welcome and thank you for this contribution.