[bobcallaway]

err was being shadowed in the assignment in L405, so the success metrics only reported parsing failures, not the db txn.

addToIndex was always wrapping its errors with "redis client", even if that was not the configured provider. this was likely leftover from when redis was the only impl

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 27.69%. Comparing base (488eb97) to head (06f3688).
⚠️ Report is 743 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/api/entries.go	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2907       +/-   ##
===========================================
- Coverage   66.46%   27.69%   -38.77%     
===========================================
  Files          92      192      +100     
  Lines        9258    20341    +11083     
===========================================
- Hits         6153     5634      -519     
- Misses       2359    13841    +11482     
- Partials      746      866      +120     

Flag	Coverage Δ
e2etests	49.84% <50.00%> (+2.28%)	⬆️
unittests	19.05% <0.00%> (-28.64%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.