Repository navigation
fix(stream): compile Solid renderer with babel-preset-solid - #1309
Merged
Merged
Conversation
unbuild esbuild used the React JSX runtime for the Solid entry, so dist/solid.mjs emitted React.createElement and threw at runtime. Fixes shikijs#1285
❌ Deploy Preview for shiki-next failed.
|
❌ Deploy Preview for shiki-matsu failed.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1309 +/- ##
=======================================
Coverage 89.87% 89.87%
=======================================
Files 81 81
Lines 3586 3586
Branches 1026 1026
=======================================
Hits 3223 3223
Misses 326 326
Partials 37 37 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 task done
antfu
added a commit
to SHUBHI-KUMARI/shiki
that referenced
this pull request
Oct 1, 2026
…1309) Co-authored-by: Anthony Fu <github@antfu.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compile the Solid stream entry with babel-preset-solid so dist/solid.mjs does not emit React.createElement. Fixes #1285.