Repository navigation
fix(markers): keep parentheses of a nested group when serializing - #1316
Merged
notatallshaw merged 1 commit intoJul 6, 2026
Merged
Conversation
str(Marker(...)) dropped the parentheses of a parenthesized group nested inside a larger and/or expression, because _format_marker unwrapped the redundant [[...]] wrapper with first reset to True. The string then reparsed with different precedence and could evaluate to the opposite result. Thread first through the unwrap so a nested group keeps the one pair of parentheses it needs.
This was referenced Jul 6, 2026
henryiii
approved these changes
Jul 6, 2026
henryiii
left a comment
Contributor
There was a problem hiding this comment.
Looks reasonable to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeps the parentheses of a nested
and/orgroup sostr(Marker(...))round-trips.Fixes #1315