Repository navigation
refactor: simplify building with cmake presets - #108
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #108 +/- ##
=======================================
Coverage 72.56% 72.56%
=======================================
Files 11 11
Lines 492 492
Branches 79 79
=======================================
Hits 357 357
Misses 92 92
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pajlada
approved these changes
Apr 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does a few things. I'll split up the different CI runners.
testsas a subproject and requirePAJLADA_SETTINGS_BUILD_TESTSto be set.rapidjsonthat we use with conan. Specifically, we want Tencent/rapidjson@862c39b. Note: We don't use rapidjson 1.1.0 in Chatterino either, but https://github.com/Tencent/rapidjson/tree/d87b698d0fcc10a5f632ecbc80a9cb2a8fa094a5. We should consider using conan for all builds or adding rapidjson as a submodule (which would duplicate it in Chatterino).conanfile.txttoconanfile.pyin order to be able to disableCMakeUserPresets.jsongeneration.conan_provider.cmake(orconan.cmakebefore) was already in this repo, so I updated it. This makes it easier to use conan.cmake -B build --preset debug-conanand it does the right thing.