Skip to content

http: fix release race between cache and snapshot - #6292

Merged
tonistiigi merged 3 commits into
moby:masterfrom
tonistiigi:http-release-fix
Oct 14, 2025
Merged

tonistiigi merged 3 commits into
moby:masterfrom
tonistiigi:http-release-fix

Conversation

@tonistiigi

Copy link
Copy Markdown
Member

Fix issue where reference pulled for HTTP URL cache key digest computation can be released before the Snapshot method of the same step runs. This can cause duplicate pulls, or if data has changed upstream it would return "digest mismatch" error.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Fixes issue where HTTP result can be released after metadata resolve
and rest of the build might pull new (potentially different) data in again.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi tonistiigi closed this Oct 14, 2025
@tonistiigi tonistiigi reopened this Oct 14, 2025
@tonistiigi
tonistiigi marked this pull request as ready for review October 14, 2025 05:01
@tonistiigi
tonistiigi requested a review from crazy-max October 14, 2025 05:01
@tonistiigi

Copy link
Copy Markdown
Member Author

Pushed additional fix for a similar case in relation to race between metadata resolve and cache/snapshot of the same URL.

@tonistiigi
tonistiigi merged commit dcbb752 into moby:master Oct 14, 2025
141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants