Repository navigation
grpcerrors: Ensure errors from errors.Join are preserved - #6226
Merged
Merged
Conversation
cpuguy83
force-pushed
the
fix_grpcerrors_unwrap
branch
from
September 16, 2025 16:43
a28de7b to
0ac75eb
Compare
Adds support for the `Unwrap() []error` interface used by `errors.Join` so that roundtripping through grpcerrors preserves types. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
fix_grpcerrors_unwrap
branch
from
September 16, 2025 17:06
0ac75eb to
c3873a9
Compare
tonistiigi
reviewed
Sep 16, 2025
tonistiigi
left a comment
tonistiigi
left a comment
Member
There was a problem hiding this comment.
If you look at Code and AsGRPCStatus then they also seem to just detect Unwrap() error directly.
Member
Author
|
Those are a little tricky since multiple errors could have a status/code. |
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
fix_grpcerrors_unwrap
branch
from
September 16, 2025 19:35
7bc0e08 to
d400e9f
Compare
tonistiigi
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the
Unwrap() []errorinterface used byerrors.Joinso that roundtripping through grpcerrors preserves types.Fixes #6225