Repository navigation
provenance: avoid missing args in history provenance - #6221
Merged
Merged
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
crazy-max
approved these changes
Sep 12, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where creating provenance multiple times (particularly for history records) would result in missing arguments. The original code was directly modifying the Capture.Args map during provenance processing, causing subsequent provenance creation to lose previously processed arguments.
- Clone the args map before processing to preserve the original arguments
- Update all references to use the cloned map instead of modifying the original
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently creating provenance changes the args array of the
Captureto the args that are later set as provenance args. This means that if provenance is created multiple times (an extra one for the history record), then the initial set of args has already been processed, and some values may be missing.