Repository navigation
Don't fail on buildkite-agent redactor add error - #21
Merged
Merged
Conversation
Closed
âĶithout Job API socket Agent-Logs-Url: https://github.com/elastic/vault-github-token-buildkite-plugin/sessions/3e87373d-5026-4b00-b6db-54effef94569 Co-authored-by: v1v <2871786+v1v@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with echoing VAULT_GITHUB_TOKEN
Don't fail on buildkite-agent redactor add error
May 22, 2026
v1v
marked this pull request as ready for review
May 22, 2026 11:08
v1v
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows 2016 (and any agent without
BUILDKITE_AGENT_JOB_API_SOCKETset),buildkite-agent redactor addfails fatally, causing the plugin to abort before the token is exported.Changes
hooks/pre-command: Made redaction non-fatal â failure emits a stderr warning and execution continues. Token redaction is best-effort; missing Job API socket should not block token delivery.tests/asset.bats: Added test asserting the hook succeeds and emits the warning whenbuildkite-agent redactor addexits non-zero.