Skip to content

Get rid of JVM specific default palantir formatter version #2685

Closed

Description

@kwin

In

private static final Jvm.Support<String> JVM_SUPPORT = Jvm.<String> support(NAME).add(8, "1.1.0").add(11, "2.28.0").add(21, "2.57.0");
the default version of palantir is determined based on the current Java version.

That is not necessary as latest spotless requires Java 17 and palantir-java-format (even in the newest version) is runnable on Java 11+. For details refer to #2451 (comment).

So it should be safe to pick 2.80.0 for all Java versions right now. This solves issues like #2625 or #2503 at least for palantir.

Activity

  1. kwin commented on Oct 15, 2025

    @kwin
    ContributorAuthor

    @nedtwigg Any idea why 2.74.0 was only deemed compatible with Java 21+ (

    private static final Jvm.Support<String> JVM_SUPPORT = Jvm.<String> support(NAME).add(8, "1.1.0").add(11, "2.28.0").add(21, "2.71.0");
    )?

  2. nedtwigg commented on Oct 15, 2025

    @nedtwigg
    Member

    i'm not sure of the history here, happy to merge something that does .add(8, "1.1.0").add(11, "2.80.0")

  3. kwin commented on Oct 15, 2025

    @kwin
    ContributorAuthor

    Why do you think you need something for java 8 given that spotless requires 17?

  4. nedtwigg commented on Oct 15, 2025

    @nedtwigg
    Member

    Ah, good point! I suppose we can remove it entirely.

  5. added 2 commits that reference this issue on Oct 16, 2025
    8b6fb9e
    d46792a
  6. added a commit that references this issue on Oct 16, 2025
    ffb7c59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions