Repository navigation
prevent crashes when process.versions is an empty object - #551
Merged
Merged
Conversation
|
cc @cthackers would be amazing to get this merged & released. |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm getting crashes if process.versions is set to
{}as it accesses.nodewith no further checks, and calls.split()onundefined. Looks like the original logic assumed that ifprocess.versionswas set, then.nodewould be too.@5saviahv sorry for the tag, just wanted to make sure you'd see this as the last commit was a little while ago ð