Skip to content

Enable some more tests on macOS - #924

Closed
keith wants to merge 4 commits into
bazelbuild:mainfrom
keith:ks/enable-cc_integration_test-on-macos
Closed

keith wants to merge 4 commits into
bazelbuild:mainfrom
keith:ks/enable-cc_integration_test-on-macos

Conversation

@keith

@keith keith commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

This just fixes minor incompatibilities

Comment on lines -913 to -914
cat "bazel-bin/${package}/aspect_out" | grep "a.*o .*b.*o .*c.*o" \
|| fail "args didn't contain tree artifact paths"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this assertion was a bug copied from another test case

@keith keith changed the title Enable cc_integration_test on macOS Enable some more tests on macOS Oct 5, 2026
Comment on lines -964 to +958
cat "bazel-bin/${package}/aspect_out" | grep "a.*o .*b.*o .*c.*o" \
|| fail "args didn't contain tree artifact paths"
grep -F "${package}/x.cc" "bazel-bin/${package}/aspect_out" \
|| fail "args didn't contain the source path"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@keith
keith marked this pull request as ready for review October 5, 2026 19:26
language = "c++",
compilation_outputs = compilation_outputs,
linking_contexts = linking_contexts,
disallow_dynamic_library = not cc_common.is_enabled(

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe here not feature_configuration.is_enabled("supports_dynamic_linker") should also work.

@keith
keith deleted the ks/enable-cc_integration_test-on-macos branch November 16, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants