Repository navigation
Quality Improvements - #3697
Merged
Merged
Quality Improvements#3697
Conversation
Member
|
Awesome, thanks for all these improvements |
Contributor
Author
I have more... But more than 20 files is unacceptable PR (by me). |
Member
|
It really depends if the changes are complex, this PR had quite a few modified files but was really quick to review since it was basically the same logical change applied on different part of the code. Feel free to do bigger PR as long as they are not too complex to review, trust your own judgement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List:
Following the contributing guidelines will make it easier for us to review and accept your PR.
Lfor long numbersisEmptyon collection instead ofsize() == 0andsize() != 0variants0from numbers to make them decimal, not octet