Skip to content

Quality Improvements - #3697

Merged
joel-costigliola merged 3 commits into
assertj:3.xfrom
cookieMr:quality_improvements
Dec 18, 2024
Merged

joel-costigliola merged 3 commits into
assertj:3.xfrom
cookieMr:quality_improvements

Conversation

@cookieMr

Copy link
Copy Markdown
Contributor

Check List:

Following the contributing guidelines will make it easier for us to review and accept your PR.


  • use capital L for long numbers
  • use isEmpty on collection instead of size() == 0 and size() != 0 variants
  • remove leading 0 from numbers to make them decimal, not octet

@joel-costigliola

Copy link
Copy Markdown
Member

Awesome, thanks for all these improvements

@joel-costigliola
joel-costigliola merged commit d92ba37 into assertj:3.x Dec 18, 2024
@joel-costigliola joel-costigliola added this to the 3.27.0 milestone Dec 18, 2024
@cookieMr

Copy link
Copy Markdown
Contributor Author

Awesome, thanks for all these improvements

I have more... But more than 20 files is unacceptable PR (by me).

@joel-costigliola

joel-costigliola commented Dec 18, 2024 •

Copy link
Copy Markdown
Member

It really depends if the changes are complex, this PR had quite a few modified files but was really quick to review since it was basically the same logical change applied on different part of the code.

Feel free to do bigger PR as long as they are not too complex to review, trust your own judgement.

@cookieMr
cookieMr deleted the quality_improvements branch December 19, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants