Skip to content

Switch to Guice constructor injection - #266

Merged
elharo merged 6 commits into
masterfrom
guice
Dec 24, 2024
Merged

elharo merged 6 commits into
masterfrom
guice

Conversation

@elharo

@elharo elharo commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@elharo
elharo requested review from gnodet and olamy December 6, 2024 15:24
@elharo elharo changed the title Switch to Guice constrcutor injection Switch to Guice constructor injection Dec 6, 2024
@elharo
elharo marked this pull request as ready for review December 7, 2024 13:03
gnodet
gnodet previously requested changes Dec 7, 2024
Comment thread pom.xml Outdated
</dependency>

<dependency>
<groupId>javax.inject</groupId>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate dependency and Maven 4 fails the build.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@elharo
elharo merged commit 7ad7463 into master Dec 24, 2024
@elharo
elharo deleted the guice branch December 24, 2024 11:31
@slawekjaranowski slawekjaranowski added this to the 3.9.1 milestone May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants