Repository navigation
fix: tighten media item update authorization (GHSA-4h2c-85f8-g3jh) - #4353
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4353 +/- ##
=========================================
- Coverage 84.9% 84.9% -0.0%
- Complexity 5670 5682 +12
=========================================
Files 291 291
Lines 23685 23698 +13
=========================================
+ Hits 20103 20113 +10
- Misses 3582 3585 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the fix merged from the temporary private fork for GHSA-4h2c-85f8-g3jh (
3dfee8061).That merge commit doesn't follow Conventional Commits, so release-please ignores it. This PR carries the changelog entry for the fix and adds a note in the code pointing at the advisory, next to the ownership check.
The fix itself is already on
main:updateMediaItemnow checks the media item's current owner before considering any change of author, requires permission to edit that specific media item, and requires permission to edit the new parent when one is set.No behavior change here, comments only.