match epub:type checking in overlays documents to content documents - #1171
Merged
Conversation
…usage message for unknown values from structure vocab)
rdeltour
requested changes
Aug 14, 2020
rdeltour
left a comment
rdeltour
left a comment
Member
There was a problem hiding this comment.
The test can be improved to check the usage (see comment), but otherwise LGTM! 👍
rdeltour
approved these changes
Sep 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Processing of epub:type is supposed to be constrained identically to content documents, which means as of 3.2 unknown values without a prefix are usage messages.
This updates the processing to match what is in place for content documents by aggregating unchecked_vocab and then iterating the value(s) after to issue usage message(s).