fix: prevent success toast when workspace selection is cancelled - #8096
Conversation
|
No actionable comments were generated in the recent review. ð âđïļ Recent review infoâïļ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ð Files selected for processing (1)
WalkthroughThe PR fixes a bug where the "Workspace opened successfully" toast appeared even when users canceled the folder selection dialog. The ChangesWorkspace open success toast fix
Estimated code review effortðŊ 1 (Trivial) | âąïļ ~5 minutes Suggested reviewers
Poem
ðĨ Pre-merge checks | â 5â Passed checks (5 passed)
âïļ Tip: You can configure your own custom pre-merge checks in the settings. âĻ Finishing Touchesð§Š Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the workspace open flow in the title bar to avoid showing a success toast unconditionally.
Changes:
- Capture the
dispatch(openWorkspaceDialog())result. - Gate the success toast behind a truthy
result.
ðĄ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d8b6701
Description
When attempting to open a workspace in Bruno, the application shows a success toast notification even if the workspace selection is canceled.
Changes Made
handleOpenWorkspaceto verify that a workspace was actually selected before showing the success toast.Before
"Workspace opened successfully"Screen.Recording.2026-05-22.at.10.49.37.PM.mov
After
Screen.Recording.2026-05-25.at.7.51.25.PM.mov
Fixes #8079
Contribution Checklist:
Summary by CodeRabbit