Skip to content

Deprecate the total_num_lanes property on the RoadEvent object - #148

Merged
j-d-b merged 3 commits into
spring-2021-releasefrom
deprecate-total-num-lanes
Mar 4, 2021
Merged

Deprecate the total_num_lanes property on the RoadEvent object#148
j-d-b merged 3 commits into
spring-2021-releasefrom
deprecate-total-num-lanes

Conversation

@j-d-b

@j-d-b j-d-b commented Dec 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR resolves #140. Specifically, the following changes were made:

  • Marked the total_num_lanes property on the RoadEvent object as deprecated, to be removed in a future version
  • Added a new business rule requiring that if lane information is provided (i.e. the lanes property on the RoadEvent is used), there must be an entry in the lanes array for every lane in the road event, not just a subset.

@j-d-b
j-d-b requested a review from chuehlien December 16, 2020 22:39
@j-d-b j-d-b linked an issue Dec 16, 2020 that may be closed by this pull request
Ambiguous value of total_num_lanes #140
Closed
chuehlien
chuehlien approved these changes Dec 18, 2020
View reviewed changes

@chuehlien chuehlien left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@j-d-b
j-d-b merged commit 4a2a9ec into spring-2021-release Mar 4, 2021
@j-d-b
j-d-b deleted the deprecate-total-num-lanes branch April 6, 2021 22:39
@j-d-b j-d-b mentioned this pull request Apr 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@chuehlien chuehlien chuehlien approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ambiguous value of total_num_lanes

2 participants

@j-d-b @chuehlien