Skip to content

IE tracker fix - #365

Closed
Voldemart96Rus wants to merge 1 commit into
umami-software:masterfrom
Voldemart96Rus:master
Closed

Voldemart96Rus wants to merge 1 commit into
umami-software:masterfrom
Voldemart96Rus:master

Conversation

@Voldemart96Rus

Copy link
Copy Markdown

@vercel

vercel Bot commented Nov 9, 2020

Copy link
Copy Markdown

@Voldemart96Rus is attempting to deploy a commit to a Personal Account owned by Mike Cao on Vercel.

@mikecao first needs to authorize it.

@Voldemart96Rus

Copy link
Copy Markdown
Author

@mikecao hello

@mikecao

mikecao commented Nov 10, 2020

Copy link
Copy Markdown
Member

I'd like to avoid bloating the tracker with polyfills if possible. Plus all the stuff you're doing with babel is already handled by buble. I think we should replace the URL functionality with equivalent logic. Looks like it's only being used in two places.

@ncovercash

Copy link
Copy Markdown

If I'm not mistaken, it looks like all the URL logic can be done with simple string operations/regex. Also, the .forEach can be replaced with a traditional for-loop for a much more streamlined solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants