Skip to content

Commit bb942da

Browse files
committed
fix(rollouts): surface an Inconclusive Experiment
An Inconclusive phase fell through to status-unknown and showed no banner, so an Experiment whose analysis matched neither its success nor its failure condition read as "no information" rather than as something needing a decision. AnalysisRunRenderer already treats Inconclusive as a warning. Inconclusive now maps to status-alert and gets a warning banner, matching that renderer.
1 parent d739a9d commit bb942da

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

‎packages/k8s-ui/src/components/resources/renderers/ExperimentRenderer.tsx‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ function phaseClass(phase?: string): string {
1717
case 'Progressing':
1818
case 'Pending':
1919
return 'status-degraded'
20+
case 'Inconclusive':
21+
return 'status-alert'
2022
case 'Failed':
2123
case 'Error':
2224
return 'status-unhealthy'
@@ -57,6 +59,14 @@ export function ExperimentRenderer({ data, onNavigate }: ExperimentRendererProps
5759
/>
5860
)}
5961

62+
{phase === 'Inconclusive' && (
63+
<AlertBanner
64+
variant="warning"
65+
title="Experiment inconclusive"
66+
message={status.message || 'An analysis matched neither its success nor failure condition.'}
67+
/>
68+
)}
69+
6070
<Section title="Status" icon={Server}>
6171
<PropertyList>
6272
<Property label="Phase" value={<span className={clsx('badge', phaseClass(phase))}>{phase}</span>} />

0 commit comments

Comments
 (0)