Repository navigation
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
YAMY1234
force-pushed
the
agent/trtllm-mha-dcp
branch
2 times, most recently
from
July 30, 2026 02:09
bd2e1ed to
1d3f225
Compare
19 of 39 tasks
5 tasks done
YAMY1234
force-pushed
the
agent/trtllm-mha-dcp
branch
from
July 30, 2026 03:04
1d3f225 to
2638eda
Compare
5 tasks done
YAMY1234
force-pushed
the
agent/trtllm-mha-dcp
branch
from
August 2, 2026 07:42
2638eda to
adc645f
Compare
YAMY1234
marked this pull request as ready for review
August 2, 2026 07:46
YAMY1234
requested review from
BBuf,
DarkSharpness,
Fridge003,
HaiShaw,
HydraQYH,
Qiaolin-Yu,
celve,
hebiao064,
ispobock,
merrymercy and
yuan-luo
as code owners
August 2, 2026 07:46
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
1 task done
Collaborator
|
Might be blocked by flashinfer-ai/flashinfer#4323 |
4 of 5 tasks
Collaborator
|
cc @thanhhao98 for vis |
5 tasks
Collaborator
Author
|
Depends on flashinfer-ai/flashinfer#4518, will rebase after flashinfer version bump |
YAMY1234
force-pushed
the
agent/trtllm-mha-dcp
branch
from
August 28, 2026 06:11
adc645f to
ccd5412
Compare
YAMY1234
requested review from
Edwardf0t1,
Ying1123,
ch-wan and
hnyls2002
as code owners
August 28, 2026 06:11
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The TRTLLM MHA decode backend does not support decode context parallelism (DCP). This PR adds the missing DCP decode path while keeping prefill on a supported backend. The common GQA KV-head mapping fix is split into #32858.
Modifications
Accuracy Tests
Qwen3.5-397B-A17B-NVFP4-V2 was evaluated on one GB300 node with TP4, 200 GSM8K examples, 8-shot prompting, temperature 0.6,
max_tokens=16384, and full decode CUDA Graph through batch size 200. The DCP4 runs include #32858.All runs completed 200/200 examples with no missing or unextractable answers. The TRTLLM MHA implementation also passed 154 targeted page-table and CUDA Graph metadata tests on ARM64/GB300 and x86/GB300, plus eager and full-graph DCP1/DCP4 serving smoke tests.
Speculative Decode Validation
Validated against merged FlashInfer #4518.
q_len1/2/4/7/8, CUDA Graph replayThe end-to-end smoke used dummy weights, so it validates integration, shape routing, and CUDA Graph replay rather than model quality. This path requires the first stable FlashInfer release containing #4518; the current SGLang FlashInfer pin (0.6.17) does not contain it.
Speed Tests and Profiling
End-to-end serving was measured on 16 GB300 GPUs with FP8 weights, FP8 E4M3 KV cache, TP16, ISL 8192, OSL 1024, concurrency 1024, 1,024 warmup requests, 5,120 measured requests, and full decode CUDA Graph through batch size 256.
DCP1 and DCP4 differ only in
dcp_size. At concurrency 1024, DCP4 improves output throughput by 39.75% over DCP1 and 37.42% over TP16, with a higher per-request TPOT. All 5,120 measured requests completed with exact 8K/1K lengths, zero request errors, zero empty outputs, and zero HTTP non-200 responses.This CC1024 result was collected on a stacked validation branch containing this PR, #32858, #32800, and the high-concurrency output-buffer capacity guard found during the run; the last guard is not yet in this PR head.
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): ❌ Run #33147127468
Latest PR Test (Extra): ❌ Run #33147127407
Latest PR Test (AMD ROCm 7.2): ❌ Run #33147127409