Skip to content

Commit 0bca288

Browse files
author
Rachel Goldfinger
committed
Add deprecation warning for Reflection::GetEnum() and Reflection::GetRepeatedEnum().
PiperOrigin-RevId: 952843763
1 parent 0394f5f commit 0bca288

1 file changed

Lines changed: 9 additions & 4 deletions

File tree

‎src/google/protobuf/message.h‎

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -633,8 +633,10 @@ class PROTOBUF_EXPORT Reflection final {
633633
const FieldDescriptor* field) const;
634634
[[nodiscard]] std::string GetString(const Message& message,
635635
const FieldDescriptor* field) const;
636-
[[nodiscard]] const EnumValueDescriptor* GetEnum(
637-
const Message& message, const FieldDescriptor* field) const;
636+
[[nodiscard]] [[deprecated(
637+
"Please use GetEnumValue() instead. GetEnum() will be "
638+
"removed in Q1 2027.")]] const EnumValueDescriptor*
639+
GetEnum(const Message& message, const FieldDescriptor* field) const;
638640

639641
// GetEnumValue() returns an enum field's value as an integer rather than
640642
// an EnumValueDescriptor*. If the integer value does not correspond to a
@@ -818,8 +820,11 @@ class PROTOBUF_EXPORT Reflection final {
818820
[[nodiscard]] std::string GetRepeatedString(const Message& message,
819821
const FieldDescriptor* field,
820822
int index) const;
821-
[[nodiscard]] const EnumValueDescriptor* GetRepeatedEnum(
822-
const Message& message, const FieldDescriptor* field, int index) const;
823+
[[nodiscard]] [[deprecated(
824+
"Please use GetRepeatedEnumValue() instead. GetRepeatedEnum() will be "
825+
"removed in Q1 2027.")]] const EnumValueDescriptor*
826+
GetRepeatedEnum(const Message& message, const FieldDescriptor* field,
827+
int index) const;
823828
// GetRepeatedEnumValue() returns an enum field's value as an integer rather
824829
// than an EnumValueDescriptor*. If the integer value does not correspond to a
825830
// known value descriptor, a new value descriptor is created. (Such a value

0 commit comments

Comments
 (0)