Repository navigation
Add start_location and end_location to Trips - #760
Closed
alexdemisch wants to merge 156 commits into
Closed
alexdemisch wants to merge 156 commits into
alexdemisch wants to merge 156 commits into
Conversation
…on, add specificity to trip_id requirements for taxi, and add separate links to MM events and Taxi events
…descriptive description
…/neil/extend-accessibility-options-in-trips-payload Rename accessibility_options_used -> accessibility_options in Trips payload
Also update agency name
Member
|
I made some minor clarifications, and I think this is ready for WG review now. It will be important to add this to dev if ready to align with Agency/Provider Unification work. Thanks! |
schnuerle
changed the base branch from
dev
to
feature-modes-passenger-services
September 6, 2022 14:46
schnuerle
changed the base branch from
feature-modes-passenger-services
to
dev
September 6, 2022 14:46
schnuerle
changed the base branch from
dev
to
feature-modes-passenger-services
September 6, 2022 14:48
|
|
schnuerle
approved these changes
Sep 6, 2022
schnuerle
left a comment
schnuerle
left a comment
Member
There was a problem hiding this comment.
Merging to latest feature branch with work in progress, instead of dev.
schnuerle
changed the base branch from
feature-modes-passenger-services
to
dev
September 6, 2022 15:01
Member
|
Thank you for your work here! Due to a technical issue around the signing of our license agreement by a GitHub user who's account/email is changed, I am adding this change here to our latest feature branch with this commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain pull request
SFMTA collects MDS trip data from its E-Moped Parking Permit Program, but only requires the start and end points of each trip, and specifically disallows the intermediate points that describe the routing of each trip. This is because we don't currently have a need for this data. SFMTA expresses this requirement in its permit language by saying "the route field shall only contain the start and end points of the trip."
The Policy Requirements endpoint allows agencies to indicate which fields are required and disallowed. In the Trips endpoint, the start and end points/time are described by the start_time, end_time, and route fields. If the route field is disallowed, the start_time and end_time fields still describe the times that trips started and ended, but the ability to communicate location is removed.
Adding start_location and end_location as optional fields would preserve the ability to communicate start and end points/times without having the route field.
Is this a breaking change
If the new fields are optional, then I don't think this is breaking.
Impacted Spec
Which spec(s) will this pull request impact?
provider