Skip to content

fix: support --X one-char aliases - #6391

Merged
mark-wiemer merged 3 commits into
mainfrom
mark-wiemer-reproduce-issue-6374
Oct 1, 2026
Merged

mark-wiemer merged 3 commits into
mainfrom
mark-wiemer-reproduce-issue-6374

Conversation

@mark-wiemer

@mark-wiemer mark-wiemer commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

AI-generated:

PR Checklist

Overview

The CLI preprocessor left every one-character alias unchanged, including long-form --t, causing 0 to be treated as a positional number instead of the timeout value. This change canonicalizes one-character aliases supplied with a long-option prefix while preserving short-option parsing, and adds coverage for --t 0 and --t=0.

mark-wiemer and others added 3 commits September 30, 2026 18:03
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.90%. Comparing base (921c161) to head (84ca884).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6391      +/-   ##
==========================================
+ Coverage   72.84%   72.90%   +0.05%     
==========================================
  Files          65       65              
  Lines        5178     5181       +3     
  Branches     1199     1178      -21     
==========================================
+ Hits         3772     3777       +5     
+ Misses       1406     1404       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mark-wiemer mark-wiemer changed the title fix: support --t timeout alias fix: support --X one-char aliases Oct 1, 2026

@mark-wiemer mark-wiemer left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@mark-wiemer
mark-wiemer merged commit 1227939 into main Oct 1, 2026
467 of 469 checks passed
@mark-wiemer
mark-wiemer deleted the mark-wiemer-reproduce-issue-6374 branch October 1, 2026 01:38
@mark-wiemer

Copy link
Copy Markdown
Member Author

Cost: $0.333 US

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug: --t option for timeout does not work with mocha 12.0.1+. It used to work with mocha 11.7.5 and earlier.

1 participant