Repository navigation
fix(docs): restore homepage logo - #6183
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
Author
mark-wiemer
approved these changes
Aug 2, 2026
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Restore logo by reading the current route from Astro.locals.starlightRoute instead of Astro.props so the homepage gets its logo back.
To give background, the old check was Astro.props.slug === "". Starlight 0.32 stopped handing route data to component overrides so that's been undefined since we went from Starlight 0.28 to 0.37 in #5574. isHomepage was never true and the logo branch just never ran. What is honestly even more problematic is that literally nothing complained either because ComponentProps on a starlight component with no declared Props widens to Record<string, any> and astro check is happy either way.
I also dropped the dead Props type and the {...Astro.props} spread since starlight's migration guide says to remove them.
One other thing i noticed in that file: the "Last updated" "" still has a Jekyll leftover as its
datetime,datetime="{{ 'now' | date: '%Y-%m-%dT%H:%M:%SZ' }}".That is not a valid datetime.