Skip to content

fix(docs): restore homepage logo - #6183

Merged
mark-wiemer merged 1 commit into
mochajs:mainfrom
mostafaNazari702:fix-logo
Aug 2, 2026
Merged

mark-wiemer merged 1 commit into
mochajs:mainfrom
mostafaNazari702:fix-logo

Conversation

@mostafaNazari702

@mostafaNazari702 mostafaNazari702 commented Jul 25, 2026 •

Copy link
Copy Markdown
Contributor

PR Checklist

Overview

Restore logo by reading the current route from Astro.locals.starlightRoute instead of Astro.props so the homepage gets its logo back.

To give background, the old check was Astro.props.slug === "". Starlight 0.32 stopped handing route data to component overrides so that's been undefined since we went from Starlight 0.28 to 0.37 in #5574. isHomepage was never true and the logo branch just never ran. What is honestly even more problematic is that literally nothing complained either because ComponentProps on a starlight component with no declared Props widens to Record<string, any> and astro check is happy either way.

I also dropped the dead Props type and the {...Astro.props} spread since starlight's migration guide says to remove them.

One other thing i noticed in that file: the "Last updated" "" still has a Jekyll leftover as its datetime, datetime="{{ 'now' | date: '%Y-%m-%dT%H:%M:%SZ' }}". That is not a valid datetime.

@github-actions

This comment has been minimized.

@mostafaNazari702

Copy link
Copy Markdown
Contributor Author

withastro/starlight#2390

@mark-wiemer
mark-wiemer merged commit 06e81a8 into mochajs:main Aug 2, 2026
13 of 14 checks passed
@mark-wiemer

Copy link
Copy Markdown
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📝 Docs: Mocha logo missing from the homepage

2 participants