Skip to content

feat: add --fail-hook-affected-tests option to report skipped tests as failed (#5519) - #6052

Merged
mark-wiemer merged 1 commit into
mochajs:v11.xfrom
smalia2001:feat/fail-hook-affected-tests
Jun 16, 2026
Merged

feat: add --fail-hook-affected-tests option to report skipped tests as failed (#5519)#6052
mark-wiemer merged 1 commit into
mochajs:v11.xfrom
smalia2001:feat/fail-hook-affected-tests

Conversation

@smalia2001

@smalia2001 smalia2001 commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown

This PR adds the option to report tests as failed when affected by hook failures.
fixes #5580

@akshah123 @claude
@JoshuaKGoldberg @mark-wiemer @smalia2001
feat: add --fail-hook-affected-tests option to report skipped tests a…
1ae41fb 
…s failed (mochajs#5519)

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Mark Wiemer <7833360+mark-wiemer@users.noreply.github.com>
Co-authored-by: Mark Wiemer <markwiemer@outlook.com>
@github-actions

github-actions Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

👋 Hi @smalia2001, thanks for the pull request! A scan flagged a concern with it. Could you please take a look?

[pr-task-completion] This PR's body is missing [x] checks on the following tasks from the PR template.

Repositories often provide a set of tasks that pull request authors are expected to complete. Those tasks should be marked as completed with a [x] in the pull request description. Please complete those tasks and mark the checks as [x] completed.

🗺️ This message was posted automatically by OctoGuide: a bot for GitHub repository best practices.

@smalia2001 smalia2001 mentioned this pull request Jun 9, 2026
Closed
3 tasks done
@mark-wiemer mark-wiemer self-assigned this Jun 11, 2026
@smalia2001

smalia2001 commented Jun 12, 2026

Copy link
Copy Markdown
Author

@mark-wiemer I just saw this issue isn't marked as status: accepting prs, oops...
I ran all tests, and they passed.
Is there anything else I should do for this PR to be merged?
btw: The tests fail when using node@25 because requireing an ESM module is possible.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jun 13, 2026
View reviewed changes

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we can merge this cleanly into v11. Thoughts @mark-wiemer ?

@mark-wiemer

mark-wiemer commented Jun 16, 2026

Copy link
Copy Markdown
Member

Test failure is known issue #6037 , lgtm, merging :)

@mark-wiemer
mark-wiemer merged commit 7830309 into mochajs:v11.x Jun 16, 2026
101 of 106 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Mocha Jun 16, 2026
@github-actions github-actions Bot mentioned this pull request Jun 16, 2026
Merged
@dhensby dhensby mentioned this pull request Aug 8, 2026
Merged
@mtrezza mtrezza mentioned this pull request Oct 26, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

@mark-wiemer mark-wiemer

Labels

None yet

Projects

Mocha
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smalia2001 @mark-wiemer @JoshuaKGoldberg @akshah123