Repository navigation
fix: fix a strange UI regression - #338178
Closed
Aldo Barreras (aldobarr) wants to merge 4 commits into
Closed
Aldo Barreras (aldobarr) wants to merge 4 commits into
Aldo Barreras (aldobarr) wants to merge 4 commits into
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Robo (@deepak1556)Matched files:
TylerLeonhardtMatched files:
Benjamin Christopher Simmonds (@benibenj)Matched files:
Anthony Kim (@anthonykim1)Matched files:
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
It contradicts the linked transition plan and contains an inaccurate production-layout fixture.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Removes the experimental Modern UI from the regular workbench while retaining Agents-specific tab and dialog styling.
Changes:
- Reverts Modern UI layout, styling, settings, theme colors, splash rendering, and telemetry.
- Removes associated menu, picker, and quick-input motion.
- Updates Agents UI fixtures and remaining shared tab presentation.
| File | Description |
|---|---|
src/vs/workbench/workbench.common.main.ts |
Stops loading Modern UI. |
src/vs/workbench/test/browser/workbenchTestServices.ts |
Removes Modern UI test hooks. |
src/vs/workbench/test/browser/parts/titlebar/titlebarPart.test.ts |
Removes shell-color assertions. |
src/vs/workbench/test/browser/parts/statusbar/statusbarPart.test.ts |
Removes floating status-bar tests. |
src/vs/workbench/test/browser/parts/editor/multiEditorTabsControl.test.ts |
Narrows modern tabs to Agents. |
src/vs/workbench/test/browser/parts/editor/editor.test.ts |
Removes tab-space setting test. |
src/vs/workbench/test/browser/parts/auxiliaryBarPart.test.ts |
Removes Modern UI variants. |
src/vs/workbench/test/browser/part.test.ts |
Removes modern part-layout test. |
src/vs/workbench/test/browser/componentFixtures/sessions/agentSessionsViewer.fixture.ts |
Updates session hierarchy fixture. |
src/vs/workbench/test/browser/componentFixtures/editor/editorTabBar.fixture.ts |
Reframes fixtures around Agents tabs. |
src/vs/workbench/test/browser/componentFixtures/editor/editorTabBar.fixture.css |
Updates Agents tab selector. |
src/vs/workbench/test/browser/componentFixtures/auxiliaryBarTitle.fixture.ts |
Removes modern title fixtures. |
src/vs/workbench/test/browser/componentFixtures/activityBarMenu.fixture.ts |
Deletes compact Activity Bar fixture. |
src/vs/workbench/test/browser/actions/menuMotion.test.ts |
Deletes menu-motion tests. |
src/vs/workbench/services/themes/browser/modernTabColorCustomizations.ts |
Rewords customization scope. |
src/vs/workbench/services/editor/test/browser/modalEditorGroup.test.ts |
Removes floating-editor test. |
src/vs/workbench/contrib/webview/test/browser/overlayWebview.test.ts |
Deletes floating-overlay tests. |
src/vs/workbench/contrib/webview/browser/overlayWebview.ts |
Removes floating-edge handling. |
src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts |
Restores default scrollbar width. |
src/vs/workbench/contrib/telemetry/browser/telemetry.contribution.ts |
Removes Modern UI telemetry. |
src/vs/workbench/contrib/splash/browser/partsSplash.ts |
Removes modern splash metadata. |
src/vs/workbench/contrib/modernUI/browser/media/titlebar.css |
Deletes modern title-bar styling. |
src/vs/workbench/contrib/modernUI/browser/media/tabs.css |
Limits modern tabs to Agents. |
src/vs/workbench/contrib/modernUI/browser/media/statusBar.css |
Deletes modern status-bar styling. |
src/vs/workbench/contrib/modernUI/browser/media/shadows.css |
Deletes modern shadow overrides. |
src/vs/workbench/contrib/modernUI/browser/media/sashHandles.css |
Deletes modern sash grips. |
src/vs/workbench/contrib/modernUI/browser/media/paneHeaders.css |
Deletes modern pane headers. |
src/vs/workbench/contrib/modernUI/browser/media/notificationsDialogs.css |
Reframes styles as Agents-only. |
src/vs/workbench/contrib/modernUI/browser/media/keyboardFocusOnly.css |
Deletes pointer-focus overrides. |
src/vs/workbench/contrib/modernUI/browser/media/editorBorder.css |
Deletes modern editor framing. |
src/vs/workbench/contrib/modernUI/browser/media/connectedEditorTabs.css |
Reframes connected tabs for Agents. |
src/vs/workbench/contrib/modernUI/browser/media/commandCenter.css |
Deletes modern command-center styling. |
src/vs/workbench/contrib/modernUI/browser/connectedEditorTabs.ts |
Removes regular-workbench strip colors. |
src/vs/workbench/contrib/mcp/browser/mcpServerActions.ts |
Removes dropdown motion options. |
src/vs/workbench/contrib/extensions/browser/extensionsActions.ts |
Removes dropdown motion options. |
src/vs/workbench/contrib/chat/test/browser/agentSessions/agentSessionsListDelegate.test.ts |
Updates height tests. |
src/vs/workbench/contrib/chat/test/browser/agentSessions/agentHostChatInputPicker.test.ts |
Removes popup-motion test. |
src/vs/workbench/contrib/chat/browser/widget/input/modelPicker/modelPickerWidget.ts |
Uses non-motion picker options. |
src/vs/workbench/contrib/chat/browser/widget/input/modelPicker/modelPickerTabbedWidget.ts |
Uses non-motion picker options. |
src/vs/workbench/contrib/chat/browser/widget/input/modelPicker/modelPickerConfiguration.ts |
Uses non-motion picker options. |
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPickerActionItem.ts |
Removes picker motion defaults. |
src/vs/workbench/contrib/chat/browser/chatSessions/chatSessionPickerActionItem.ts |
Updates picker helper usage. |
src/vs/workbench/contrib/chat/browser/agentSessions/experiments/agentTitleBarStatusWidget.ts |
Removes menu motion. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsViewer.ts |
Removes compact row constants. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsControl.ts |
Uses fixed default row heights. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/media/agentHostModePicker.css |
Removes popup animations. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostChatInputPicker.ts |
Updates picker helper usage. |
src/vs/workbench/contrib/chat/browser/agentPluginsView.ts |
Removes menu motion. |
src/vs/workbench/common/theme.ts |
Removes Modern UI colors. |
src/vs/workbench/common/editor.ts |
Removes tab-space option. |
src/vs/workbench/browser/workbench.contribution.ts |
Removes Modern UI settings. |
src/vs/workbench/browser/parts/views/viewPaneContainer.ts |
Removes floating bottom gap. |
src/vs/workbench/browser/parts/titlebar/titlebarPart.ts |
Restores classic title styling. |
src/vs/workbench/browser/parts/statusbar/statusbarPart.ts |
Restores classic status-bar sizing. |
src/vs/workbench/browser/parts/panel/panelPart.ts |
Restores classic border sizing. |
src/vs/workbench/browser/parts/paneCompositePart.ts |
Removes floating-card layout. |
src/vs/workbench/browser/parts/paneCompositeBar.ts |
Removes compact icon variables. |
src/vs/workbench/browser/parts/globalCompositeBar.ts |
Removes menu motion. |
src/vs/workbench/browser/parts/editor/multiEditorTabsControl.ts |
Updates tab-fill terminology. |
src/vs/workbench/browser/parts/editor/media/multieditortabscontrol.css |
Updates Agents terminology. |
src/vs/workbench/browser/parts/editor/editorTabsControl.ts |
Removes reserved-action behavior. |
src/vs/workbench/browser/parts/editor/editorPart.ts |
Removes floating editor layout. |
src/vs/workbench/browser/parts/editor/editor.ts |
Removes tab-space defaults. |
src/vs/workbench/browser/parts/activitybar/media/activitybarpart.css |
Restores fixed Activity Bar width. |
src/vs/workbench/browser/parts/activitybar/media/activityaction.css |
Restores fixed action sizing. |
src/vs/workbench/browser/part.ts |
Restores standard part heights. |
src/vs/workbench/browser/actions/menuMotion.ts |
Deletes workbench menu-motion helper. |
src/vs/workbench/browser/actions/layoutActions.ts |
Removes density controls. |
src/vs/sessions/contrib/providers/agentHost/test/browser/agentHostModePicker.fixture.ts |
Removes Modern UI fixture classes. |
src/vs/sessions/contrib/editor/test/browser/editor.contribution.test.ts |
Updates Agents tab tests. |
src/vs/sessions/browser/workbench.ts |
Removes obsolete layout methods. |
src/vs/sessions/browser/parts/editorParts.ts |
Removes tab-space override. |
src/vs/platform/theme/electron-main/themeMainServiceImpl.ts |
Removes splash part bounds. |
src/vs/platform/theme/common/themeService.ts |
Removes modern splash fields. |
src/vs/platform/quickinput/test/browser/quickinput.test.ts |
Removes quick-input motion tests. |
src/vs/platform/quickinput/browser/quickInputController.ts |
Removes close-animation lifecycle. |
src/vs/platform/quickinput/browser/media/quickInput.css |
Deletes quick-input animations. |
src/vs/platform/actionWidget/test/browser/actionWidgetDropdown.test.ts |
Removes motion-default test. |
src/vs/platform/actionWidget/browser/actionWidgetDropdown.ts |
Removes dropdown motion defaults. |
src/vs/platform/actionWidget/browser/actionWidget.css |
Deletes dropdown animations. |
src/vs/code/test/electron-browser/partsSplash.test.ts |
Removes modern splash tests. |
src/vs/code/electron-browser/workbench/partsSplash.ts |
Restores classic splash colors. |
src/vs/base/test/browser/ui/dropdown/dropdown.test.ts |
Updates dropdown expectations. |
src/vs/base/test/browser/ui/contextview/contextview.test.ts |
Removes menu-motion test. |
src/vs/base/test/browser/dom.test.ts |
Generalizes class-search test names. |
src/vs/base/common/codiconsLibrary.ts |
Removes density icons. |
src/vs/base/browser/ui/menu/menu.ts |
Restores direct menu shadows. |
src/vs/base/browser/ui/dropdown/dropdown.ts |
Removes default menu animation. |
src/vs/base/browser/ui/contextview/contextview.ts |
Removes menu-motion infrastructure. |
package.json |
Removes CSS performance script. |
extensions/theme-tomorrow-night-blue/themes/tomorrow-night-blue-color-theme.json |
Removes modern border color. |
extensions/theme-solarized-light/themes/solarized-light-color-theme.json |
Removes Modern UI colors. |
extensions/theme-solarized-dark/themes/solarized-dark-color-theme.json |
Removes Modern UI colors. |
extensions/theme-red/themes/Red-color-theme.json |
Removes Modern UI colors. |
extensions/theme-quietlight/themes/quietlight-color-theme.json |
Removes connected-tab colors. |
extensions/theme-monokai/themes/monokai-color-theme.json |
Removes modern border color. |
extensions/theme-monokai-dimmed/themes/dimmed-monokai-color-theme.json |
Removes Modern UI colors. |
extensions/theme-kimbie-dark/themes/kimbie-dark-color-theme.json |
Removes modern border color. |
extensions/theme-defaults/themes/light_vs.json |
Removes Modern UI colors. |
extensions/theme-defaults/themes/light_modern.json |
Removes Modern UI colors. |
extensions/theme-defaults/themes/dark_vs.json |
Removes Modern UI colors. |
extensions/theme-defaults/themes/dark_modern.json |
Removes Modern UI colors. |
extensions/theme-defaults/themes/2026-light.json |
Removes connected/surface colors. |
extensions/theme-defaults/themes/2026-dark.json |
Removes connected/surface colors. |
extensions/theme-abyss/themes/abyss-color-theme.json |
Removes Modern UI colors. |
build/lib/test/rootAnchoredHas.test.ts |
Renames selector test fixture. |
build/lib/stylelint/vscode-known-variables.json |
Removes deleted CSS variables. |
.github/skills/design-philosophy/SKILL.md |
Updates casing guidance. |
.github/skills/auto-perf-optimize/scratchpad/README.md |
Removes CSS benchmark documentation. |
.github/instructions/design-tokens.instructions.md |
Documents Activity Bar icon exception. |
.github/instructions/css-best-practices.instructions.md |
Rewords performance example. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…Agents editor tabs' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
🤬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a very strange UI regression with VS Code that is just completely destroying developer comfort on the workbench. I've noticed a lot of people complaining about it on #334285 about it.
This PR fixes the regression and things look great again. Fixes #334285