[ktz03]

Linked Issue

Closes #7229

Description

Sibling of #6546 / #6547 for the Valkey store.

Search scoring hardcoded max(0.0, 1.0 - raw_distance), which is only correct for cosine. With L2 (already accepted by create_col(distance=...)), unbounded distances collapse almost every hit with d > 1 to 0.0.

This PR:

• Adds distance to ValkeyConfig / ValkeyDB (default COSINE)
• Uses self.distance in _create_index (was hardcoded COSINE)
• Persists create_col(..., distance=...) onto self.distance for scoring
• Adds _distance_to_score mirroring fix(vector_stores/s3_vectors): make search score metric-aware #6547:
  • COSINE / IP → max(0, 1 - d)
  • L2 → 1 / (1 + d)

Type of Change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Refactor (no functional changes)
• Documentation update

Breaking Changes

N/A. Cosine (the default) is unchanged; only L2 scoring is corrected, and index init now respects the configured metric.

Test Coverage

• I added/updated unit tests
• I added/updated integration tests
• I tested manually (describe below)
• No tests needed (explain why)

Added regression tests in tests/vector_stores/test_valkey.py:

• cosine keeps 1 - d
• L2 uses the bounded map and does not collapse d=4.0 to 0
• create_col(distance="L2") updates scoring, not only FT.CREATE

Checklist

• My code follows the project's style guidelines
• I have performed a self-review of my code
• I have added tests that prove my fix works
• New and existing tests pass locally
• I have updated documentation if needed

[CLAassistant]

All committers have signed the CLA.

[github-actions]

Thanks for taking the time to open this.

We only review pull requests that fix an issue we have already agreed to take on, so this one is closed for now.
Closed does not mean rejected. It means it is not in the queue yet, and reopening takes about a minute.

To get it reviewed:

1. Make sure an issue describes the problem, with the version you are on, a runnable reproduction, and the real output or traceback you saw.
2. Link it from this pull request description with Closes #<number>.
3. Ask a maintainer to label that issue accepted. This pull request reopens by itself when they do.

Issue already labeled accepted? Just add Closes #<number> to the description. That reopens this too.

Documentation-only changes skip this gate entirely.

See CONTRIBUTING.md for the full policy.

[github-actions]

Hi @ktz03, thanks for opening this pull request.

This is just a soft check: you are not yet in this repo's vouched contributor list (.github/VOUCHED.td). Nothing is blocked and there is nothing you need to do.

A maintainer can vouch for you by commenting !vouch @ktz03 on any issue.

[ktz03]

Pending accepted on #7229 (mem0 PR gate). Implementation mirrors #6547. Will auto-reopen once labeled.

[github-actions]

An accepted issue is linked now, so this is open again and ready for review.