Repository navigation
Do match type reduction atPhaseNoLater than ElimOpaque - #20017
Merged
Merged
Conversation
EugeneFlesselle
changed the title
EugeneFlesselle
marked this pull request as ready for review
March 26, 2024 13:09
EugeneFlesselle
enabled auto-merge (rebase)
March 26, 2024 13:49
odersky
approved these changes
Mar 27, 2024
odersky
left a comment
odersky
left a comment
Contributor
There was a problem hiding this comment.
That was easy, after all! LGTM
Member
|
Nice fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a match type pattern is an opaque type, we use its bounds when checking the validity of the pattern.
Following the
ElimOpaquephase however, the pattern is beta-reduced (as normal applied type aliases), which may result in an illegal pattern, and hence an ErrorType.We initially discussed doing the changes in the TypeComparer
reduceMatchWith, but I think theatPhaseNoLater(elimOpaquePhase)should be in the reduced method of MatchType, for the footprint computation to happen in the same context.Fixes #19434
Also allows to keep
bad-footprint.scalain #19954