Skip to content

Resumable: address Julian's second review pass - #3574

Open
LPardue wants to merge 3 commits into
mainfrom
resumable-reschke-review-2
Open

LPardue wants to merge 3 commits into
mainfrom
resumable-reschke-review-2

Conversation

@LPardue

@LPardue LPardue commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Addresses some comments from Julian's second review pass: https://www.w3.org/mid/0541c103-146b-4ac2-a2e6-f984d78f5ac3@gmx.de

  • Point Untrusted Input at HTTP's security considerations
    • The section restated advice that applies to any upload. RFC 9110 Sections 17.3 and 17.4 cover the same risks, so cite them instead. This removes the metadata validation MUST.
  • Restate the parallel transfer rule in upload terms
    • Names the upload creation and upload append requests. The requirement is unchanged.
  • Drop redundant "in bytes" from Upload-Offset and Upload-Length
    • The Offset and Length sections already define both values as a number of bytes.

The section restated advice that applies to any upload. RFC 9110
Sections 17.3 and 17.4 cover the same risks, so cite them instead.
…ngth

The Offset and Length sections already define both values as a number
of bytes, so the field definitions don't need to repeat the unit.
# Concurrency

Resumable uploads, as defined in this document, do not permit uploading representation data in parallel requests for the same upload. The client MUST NOT perform multiple representation data transfers for the same upload resource in parallel, or perform representation data transfers while the creation of the same upload resource is still in progress.
This document does not support parallel requests that transfer representation data to the same upload resource. The client MUST NOT send an upload append request ({{upload-appending}}) while an upload creation request ({{upload-creation}}) or another upload append request for the same upload resource is still in progress.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This phrasing is good, I think. We don't define parallel uploading in this document, but this could be specified by other documents in the future (see the current proposal in the WG). So resumable uploads and parallel uploading aren't always exclusive. It's just not part of this document.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants