Skip to content

Move cache out of the worktree - #165

Closed
krlmlr wants to merge 4 commits into
hendrikmuhs:mainfrom
krlmlr:parallel-dir
Closed

krlmlr wants to merge 4 commits into
hendrikmuhs:mainfrom
krlmlr:parallel-dir

Conversation

@krlmlr

@krlmlr krlmlr commented Oct 8, 2023

Copy link
Copy Markdown
Contributor

For #96.

@krlmlr

krlmlr commented Oct 8, 2023

Copy link
Copy Markdown
Contributor Author

This action in action: https://github.com/tidyverse/blob/actions/runs/6445932389/job/17500507262#step:6:3405 .

Any idea why sccache fails?

@hendrikmuhs

Copy link
Copy Markdown
Owner

Did you look at the test? Maybe you have to adapt he location at this line:

https://github.com/hendrikmuhs/ccache-action/blob/main/.github/workflows/tests.yml#L59

@krlmlr

krlmlr commented Oct 15, 2023

Copy link
Copy Markdown
Contributor Author

Looks slightly better now, two tests are still failing. Do you agree that moving the cache out of tree is a good idea?

@hendrikmuhs

Copy link
Copy Markdown
Owner

Looks slightly better now, two tests are still failing. Do you agree that moving the cache out of tree is a good idea?

yes, I think this is a good idea

@krlmlr

krlmlr commented Aug 1, 2024

Copy link
Copy Markdown
Contributor Author

Let's see how far we get with the current implementation after #217. I still think the cache shouldn't live inside the worktree, let's discuss when this becomes an issue.

@krlmlr krlmlr closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants