Repository navigation
fix(bigtable): fix TestRetryApplyBulk_OverallRequestFailure test interceptor - #20574
Merged
mutianf merged 3 commits intoSep 24, 2026
Merged
Conversation
The success branch of the stream interceptor returned nil without calling handler(srv, ss), so the fake server never wrote any MutateRowsResponse entries. The client received a clean stream with zero entries for its one mutation and raised "missing entry result in MutateRows response". Delegate to handler(srv, ss) on the success path, matching the pattern used by all other interceptors in retry_test.go. Change-Id: I7eff0cbabb511ebae2a3480d18de4eda862d6922
product-auto-label
Bot
added
the
api: bigtable
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the errInjector function in bigtable/retry_test.go to simplify the error injection logic. The review identifies a critical bug where the fallback handler call incorrectly passes ctx instead of the required srv interface, which would lead to a runtime panic.
Change-Id: I088191725972d2948231885ae0ea58d0b4a9926e
sushanb
approved these changes
Sep 24, 2026
mutianf
pushed a commit
that referenced
this pull request
Sep 25, 2026
🤖 I have created a release *beep* *boop* --- ## [1.58.0](bigtable/v1.57.0...bigtable/v1.58.0) (2026-09-25) ### Features * **all:** Update supported go versions ([#20520](#20520)) ([90413d3](90413d3)) * **bigtable:** Support hot duration, disabled, and effective backup policy ([#20573](#20573)) ([da2bfcc](da2bfcc)) * Update API sources and regenerate ([#20526](#20526)) ([e6f37a3](e6f37a3)) * Update API sources and regenerate ([#20570](#20570)) ([cc91d66](cc91d66)) * Update API sources and regenerate. ([e6f37a3](e6f37a3)) ### Bug Fixes * **bigtable:** Detect omitted MutateRows response entries in ApplyBulk ([#20557](#20557)) ([68b3f33](68b3f33)) * **bigtable:** Fix TestRetryApplyBulk_OverallRequestFailure test interceptor ([#20574](#20574)) ([25bc085](25bc085)) * **various:** Address format directive issues ([#20547](#20547)) ([e2e1047](e2e1047)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errCount >= 3) returnednilwithout callinghandler(srv, ss), so the fake server never wrote anyMutateRowsResponseentries.bigtable: missing entry result in MutateRows response.handler(srv, ss)on the success path, matching the pattern used by every other interceptor inretry_test.go.Test plan
go test -run TestRetryApplyBulk_OverallRequestFailure -v -count=1 ./bigtable/passesgo test -run TestRetryApplyBulk -v -count=1 ./bigtable/— all bulk retry tests pass