Repository navigation
fix(bigtable): detect omitted MutateRows response entries in ApplyBulk - #20557
Merged
Merged
Conversation
product-auto-label
Bot
added
the
api: bigtable
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces tracking for missing entry results in MutateRows responses during bulk mutations, marking unseen entries with an internal error upon EOF. It also adds bounds checking for entry indices and includes a unit test to verify this behavior. The review feedback points out a potential nil pointer dereference when accessing entry.Status directly, recommending a defensive nil check to prevent panics.
sushanb
approved these changes
Sep 21, 2026
mutianf
enabled auto-merge (squash)
September 22, 2026 01:59
mutianf
added
the
kokoro:force-run
parthea
added
kokoro:force-run
kokoro-team
removed
kokoro:run
mutianf
pushed a commit
that referenced
this pull request
Sep 25, 2026
🤖 I have created a release *beep* *boop* --- ## [1.58.0](bigtable/v1.57.0...bigtable/v1.58.0) (2026-09-25) ### Features * **all:** Update supported go versions ([#20520](#20520)) ([90413d3](90413d3)) * **bigtable:** Support hot duration, disabled, and effective backup policy ([#20573](#20573)) ([da2bfcc](da2bfcc)) * Update API sources and regenerate ([#20526](#20526)) ([e6f37a3](e6f37a3)) * Update API sources and regenerate ([#20570](#20570)) ([cc91d66](cc91d66)) * Update API sources and regenerate. ([e6f37a3](e6f37a3)) ### Bug Fixes * **bigtable:** Detect omitted MutateRows response entries in ApplyBulk ([#20557](#20557)) ([68b3f33](68b3f33)) * **bigtable:** Fix TestRetryApplyBulk_OverallRequestFailure test interceptor ([#20574](#20574)) ([25bc085](25bc085)) * **various:** Address format directive issues ([#20547](#20547)) ([e2e1047](e2e1047)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.