[quirogas]

No description provided.

[gemini-code-assist]

Code Review

This pull request updates several Google Cloud client libraries, including adding IAM permission documentation to BigQuery v2, introducing new OAuth scopes and markup syntax support to Chat v1, and implementing workspace branch management methods in Dataform v1beta1. In the Compute v1 preview client, defensive nil-guards were added to req when checking ParentId. The review feedback recommends removing these defensive nil-guards on req because the parameter is guaranteed to be non-nil by the caller, and such guards can mask bugs by silently no-oping instead of allowing a nil-panic to surface.

[gemini-code-assist]

Avoid adding defensive nil-guards on req since it is a parameter whose non-nil status is guaranteed by the caller. According to the general rules, such guards can mask real bugs by silently no-oping instead of allowing a nil-panic to surface the caller's mistake.

Suggested change

	if req != nil && req.ParentId != nil {
	params.Add("parentId", fmt.Sprintf("%v", req.GetParentId()))
	}
	if req.ParentId != nil {
	params.Add("parentId", fmt.Sprintf("%v", req.GetParentId()))
	}

References

1. Do not add defensive nil-guards on variables or parameters where invariants guaranteed by construction or call sites ensure they will never be nil.

[gemini-code-assist]

Avoid adding defensive nil-guards on req since it is a parameter whose non-nil status is guaranteed by the caller. According to the general rules, such guards can mask real bugs by silently no-oping instead of allowing a nil-panic to surface the caller's mistake.

Suggested change

	if req != nil && req.ParentId != nil {
	params.Add("parentId", fmt.Sprintf("%v", req.GetParentId()))
	}
	if req.ParentId != nil {
	params.Add("parentId", fmt.Sprintf("%v", req.GetParentId()))
	}

References

1. Do not add defensive nil-guards on variables or parameters where invariants guaranteed by construction or call sites ensure they will never be nil.

[snippet-bot]

Here is the summary of changes.

You are about to add 5 region tags.

• dataform/examples/apiv1beta1/Client/CheckoutWorkspaceBranch/main.go:17, tag dataform_v1beta1_generated_Dataform_CheckoutWorkspaceBranch_sync
• dataform/examples/apiv1beta1/Client/DeleteBranch/main.go:17, tag dataform_v1beta1_generated_Dataform_DeleteBranch_sync
• dataform/examples/apiv1beta1/Client/FetchCurrentWorkspaceBranch/main.go:17, tag dataform_v1beta1_generated_Dataform_FetchCurrentWorkspaceBranch_sync
• dataform/examples/apiv1beta1/Client/FetchWorkspaceBranches/main.go:17, tag dataform_v1beta1_generated_Dataform_FetchWorkspaceBranches_sync
• dataform/examples/apiv1beta1/Client/SyncWorkspaceRefs/main.go:17, tag dataform_v1beta1_generated_Dataform_SyncWorkspaceRefs_sync

---

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

• Refresh this comment

[noahdietz]

Note that the changes to the preview/internal/compute client are intentional. See source CL cl/966098511